From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FA9FF9D0D6 for ; Tue, 14 Apr 2026 14:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XKp7fQ2vN/KH7ssg67+Ff+T7vWtc2H3eKFC/m16ZHjA=; b=fAI5efcEivT6dWpj0qvBcYoGXc 0+ZNDni80Oq9G6TOCZnHOzuT/ZLO71DNKh445oimIUIldV0ssrHVoDfHLuo6mnf4Z2MC3MHYnaTrP ZWyX1gw0korkb94chfZs+3wDhX9siqEFue2ig1USU783blijy1pr01pVSq1e630l2CLHCqay9urQ3 jfkeHuUdcymsc94+PVOO618KgDri8ivLmZoJI4q5fWbr1Z9lNuWzKB84j74b4wufefCZXzGM51wHl s6izwzvchDSoEInQJBeii5fifjXjX/UN5M9j9nblFz6xaHz8voSSU7K5FUUx5JRUYtHYqMcVbJgVl 6WXPMNGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCf7z-0000000HTtH-1EGd; Tue, 14 Apr 2026 14:52:35 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCf7w-0000000HTsu-3lbe for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2026 14:52:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E09494043D; Tue, 14 Apr 2026 14:52:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B96E0C19425; Tue, 14 Apr 2026 14:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776178351; bh=5bQ2lHVEbUt1BbmpoYLYzkIihN+c2/TvvPh6i/WsRss=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lN9MxfEQYQZjnYDLumSvHszeXtdk7K/FCPHAcHUC3Rq8vBripPpT2YKSjVIbRAUE0 l0nqm8USYO8dcqev/v5ES6GrsiyxubUNd3Qutw+H934GyrAHZaGBUMyORbGGz2G/Na cqcfvT/+HPB1Eqk3Ajzi/DMtxqdKCZ+AwBje9ec5ZkqKnfkZ3mjXDdnujWr+Xcorw4 i93cZs+4EMRBLPTKYKgwUjCf4RgUcRnPWO2BPETG56kl3eSLWJ6RpwTYfu6CqMTJ1L X+L3OZD8FMyHP4ZVo3b+D+ARjCpsi52HxQP8nKSC+i8jYlLgJ96PcY+G/y1DrQegUm x35w32OJLH+JQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wCf7t-0000000Bbzt-1riT; Tue, 14 Apr 2026 14:52:29 +0000 Date: Tue, 14 Apr 2026 15:52:29 +0100 Message-ID: <86ik9t387m.wl-maz@kernel.org> From: Marc Zyngier To: Vincent Donnefort Cc: oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: Re-allow hyp tracing HVCs for [nh]VHE In-Reply-To: <20260414100231.1859687-1-vdonnefort@google.com> References: <20260414100231.1859687-1-vdonnefort@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vdonnefort@google.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260414_075232_975970_696E2BAD X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Apr 2026 11:02:31 +0100, Vincent Donnefort wrote: > > The introduction of __KVM_HOST_SMCCC_FUNC_MAX_NO_PKVM excluded hyp > tracing HVCs from the common [nh]VHE/pKVM list. Re-allow them. > > Signed-off-by: Vincent Donnefort > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > index 37414440cee7..11dcdf434971 100644 > --- a/arch/arm64/include/asm/kvm_asm.h > +++ b/arch/arm64/include/asm/kvm_asm.h > @@ -72,6 +72,14 @@ enum __kvm_host_smccc_func { > __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_range, > __KVM_HOST_SMCCC_FUNC___kvm_flush_cpu_context, > __KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff, > + __KVM_HOST_SMCCC_FUNC___tracing_load, > + __KVM_HOST_SMCCC_FUNC___tracing_unload, > + __KVM_HOST_SMCCC_FUNC___tracing_enable, > + __KVM_HOST_SMCCC_FUNC___tracing_swap_reader, > + __KVM_HOST_SMCCC_FUNC___tracing_update_clock, > + __KVM_HOST_SMCCC_FUNC___tracing_reset, > + __KVM_HOST_SMCCC_FUNC___tracing_enable_event, > + __KVM_HOST_SMCCC_FUNC___tracing_write_event, > __KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs, > __KVM_HOST_SMCCC_FUNC___vgic_v3_restore_vmcr_aprs, > __KVM_HOST_SMCCC_FUNC___vgic_v5_save_apr, > @@ -100,14 +108,6 @@ enum __kvm_host_smccc_func { > __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_load, > __KVM_HOST_SMCCC_FUNC___pkvm_vcpu_put, > __KVM_HOST_SMCCC_FUNC___pkvm_tlb_flush_vmid, > - __KVM_HOST_SMCCC_FUNC___tracing_load, > - __KVM_HOST_SMCCC_FUNC___tracing_unload, > - __KVM_HOST_SMCCC_FUNC___tracing_enable, > - __KVM_HOST_SMCCC_FUNC___tracing_swap_reader, > - __KVM_HOST_SMCCC_FUNC___tracing_update_clock, > - __KVM_HOST_SMCCC_FUNC___tracing_reset, > - __KVM_HOST_SMCCC_FUNC___tracing_enable_event, > - __KVM_HOST_SMCCC_FUNC___tracing_write_event, > }; > > #define DECLARE_KVM_VHE_SYM(sym) extern char sym[] > diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c > index 73f2e0221e70..8f7582d57ab5 100644 > --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c > +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c > @@ -709,6 +709,14 @@ static const hcall_t host_hcall[] = { > HANDLE_FUNC(__kvm_tlb_flush_vmid_range), > HANDLE_FUNC(__kvm_flush_cpu_context), > HANDLE_FUNC(__kvm_timer_set_cntvoff), > + HANDLE_FUNC(__tracing_load), > + HANDLE_FUNC(__tracing_unload), > + HANDLE_FUNC(__tracing_enable), > + HANDLE_FUNC(__tracing_swap_reader), > + HANDLE_FUNC(__tracing_update_clock), > + HANDLE_FUNC(__tracing_reset), > + HANDLE_FUNC(__tracing_enable_event), > + HANDLE_FUNC(__tracing_write_event), > HANDLE_FUNC(__vgic_v3_save_aprs), > HANDLE_FUNC(__vgic_v3_restore_vmcr_aprs), > HANDLE_FUNC(__vgic_v5_save_apr), > @@ -735,14 +743,6 @@ static const hcall_t host_hcall[] = { > HANDLE_FUNC(__pkvm_vcpu_load), > HANDLE_FUNC(__pkvm_vcpu_put), > HANDLE_FUNC(__pkvm_tlb_flush_vmid), > - HANDLE_FUNC(__tracing_load), > - HANDLE_FUNC(__tracing_unload), > - HANDLE_FUNC(__tracing_enable), > - HANDLE_FUNC(__tracing_swap_reader), > - HANDLE_FUNC(__tracing_update_clock), > - HANDLE_FUNC(__tracing_reset), > - HANDLE_FUNC(__tracing_enable_event), > - HANDLE_FUNC(__tracing_write_event), > }; Why isn't it sufficient to reorder the enum? Thanks, M. -- Without deviation from the norm, progress is not possible.