From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F200CAC582 for ; Tue, 9 Sep 2025 17:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jE8R0EV96UUf5BL0lUpzEh3F/qQnkIHgeoj5oLjn1g0=; b=mlYs/75ycAEJ20t47IZgZCPleE ELMZc5IM7EESWI9r+6KnQAgw4gJ1ANgryxZAAtK4FDyeWSrTvA4qLM08tuRxSsSZTOHwny+9WsNLZ Jvab+DTfs/cG72fnr9InDHevfdm3LNKb3uRqbO9rpX0jNTbjqGDI7oaXNUDzifY/oCRMJ3Aq7IkDw 8/bc9co1asCbPgLNtjYuzdq+1Bglq7rfTlGPd9SbPPkSLs2nSCE7/DUFzqLQ7SZ5chyo4/9nEWYHG BV5PPnux60lRZP+pYXYh5s2Edd6lq0WuDuHV3xMqH2U2mUkBJNu9P6jeyWC9MQKa5X1LIi7AD2JdY uwOFX/Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw1wK-00000008oNM-26J6; Tue, 09 Sep 2025 17:15:32 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvwQ3-00000006h2n-33vI for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Sep 2025 11:21:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jE8R0EV96UUf5BL0lUpzEh3F/qQnkIHgeoj5oLjn1g0=; b=kbcO1gJHvSlS1/GcaSGy+c3QRN JmuEYDhJYHp7wv6T1vdBGjNvgxW5MGT+CxEDYChe+YjAcq72BG+DR89QqrVqShMwWOaG0g3MfZa6A 6Tzmd1WdXEkj1+CGrMpbBWfKPpXR6gSggxn/6s+iRpwNStTtXqBc7h8CQ8iZnyeVKTbRY3kVhEKeE x5ukFUfqRtEOoiR1yT1AhpFzy47/91GRqT9VBj9fjdV8YyCcfSML02mOGFE1tOBjYgeO+3rZjGFrV FUACp3dVk1f+oHrhrpQg4rKxpcJdgLTL1b/h/mROvrwb6iKi4U0SQgGYh9vVBuuRqJbBG95Xiai1A tz9hkfng==; Received: from sea.source.kernel.org ([172.234.252.31]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvwQ0-00000005J5t-3UJE for linux-arm-kernel@lists.infradead.org; Tue, 09 Sep 2025 11:21:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C127B40372; Tue, 9 Sep 2025 11:21:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F9EDC4CEF4; Tue, 9 Sep 2025 11:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757416904; bh=WGVbI7np7xhsccUcZ2mq8FQt+c4KbxvQmTFbkCyFxsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=spnzCgdCWnXyXf6fPVwUl5AFWzK/6O6noknQOaiNR743uSzQ4li/wAT8TINQ8Zb8h 2HmJNNYdO8hH+26KkHtfTZ8jgJ65/zTew228hvgi8OSovHBKFDJPs+7sHTClAUFRhM z6vXpNscUiyQYg3nbezYFN1d65jc4mHeYM7SqA5wKSSGZFRxTw9CQsiZIfCQ/eH+Tv c14Mtwbke+oIyH6nT4sdxMXMh/KKCzRYN7nDwU2nHk/5mL+7ORoShsLuBIYW74ZLWU xpJlKzqNR4wURL4jPeSwKM3AJX50gJD2ZOCG/UdgoMb7YQ/TIO0sor3B43Gin6CiOX UoTjIseNn4tgg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uvwPu-00000004ewP-13PZ; Tue, 09 Sep 2025 11:21:42 +0000 Date: Tue, 09 Sep 2025 12:21:41 +0100 Message-ID: <86ikhrdg6y.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Mark Rutland , Will Deacon , "Rafael J. Wysocki" , Rob Herring , Saravana Kannan , Greg Kroah-Hartman , Sven Peter , Janne Grunau , Suzuki K Poulose , James Clark Subject: Re: [PATCH 14/25] genirq: Update request_percpu_nmi() to take an affinity In-Reply-To: <877by8vu0v.ffs@tglx> References: <20250908163127.2462948-1-maz@kernel.org> <20250908163127.2462948-15-maz@kernel.org> <877by8vu0v.ffs@tglx> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, mark.rutland@arm.com, will@kernel.org, rafael@kernel.org, robh@kernel.org, saravanak@google.com, gregkh@linuxfoundation.org, sven@kernel.org, j@jannau.net, suzuki.poulose@arm.com, james.clark@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250909_122149_036610_945928F6 X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 09 Sep 2025 10:45:36 +0100, Thomas Gleixner wrote: > > On Mon, Sep 08 2025 at 17:31, Marc Zyngier wrote: > > @@ -2564,13 +2566,14 @@ int request_percpu_nmi(unsigned int irq, irq_handler_t handler, > > !irq_supports_nmi(desc)) > > return -EINVAL; > > > > - /* The line cannot already be NMI */ > > - if (irq_is_nmi(desc)) > > + /* The line cannot be NMI already if the new request covers all CPUs */ > > + if (irq_is_nmi(desc) && > > + (!affinity || cpumask_equal(affinity, cpu_possible_mask))) > > return -EINVAL; > > This check looks odd. What makes sure that the affinities do not > overlap? The following patch in the series does, at the point of adding the new irqaction to the list. This is modelled after the current handling of shared interrupts. M. -- Without deviation from the norm, progress is not possible.