From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03468C52D7C for ; Wed, 21 Aug 2024 11:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2MYP8wT3QcjZd+3Izvpdod6s2Gv6ILM2dHqre8UVzyY=; b=XQRYZ5tB1YQlabQVwU5BHajH88 aj6C9KWWcv11szg0PSlUdqfTtZaQFP/oKCPXGRWwD9DU2iq8sim0b2qtr5nnuBYv1Bo8lalThgHfe btcuzBW5OjpBWHQt2DrAFz7RyOnVMrOsZ35bRNXIs1OPbukzfu5D87atFwVPmwrac4ZXPhsibz9Ec QqnCfeoCvkf0KbyuHTwKMqlBmbBtJlWkqSnU74dfqOWixeKv3hovFXtFPZ89haaS58jczZXS2IGwH t+uOkGOGNQ/g2KShyr6Xz9Cg/eSn6NKXoqcbdm31T1Z/LoglsjFWt4l0/zqUHXb6Q3tQ5OdJ6TdsT ElzjcIfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgjIp-00000008cvz-1tfc; Wed, 21 Aug 2024 11:14:59 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgjHv-00000008chh-0bea for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 11:14:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6171BCE0E5F; Wed, 21 Aug 2024 11:14:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 240F1C32782; Wed, 21 Aug 2024 11:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724238840; bh=ltZxB1ov+Y4a3/+KK1P2wxvY2WYfLUrfItKSecJnu9c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QP5H6CuXkR6voKv0xKrbGXHYzT17/dj688f7YYjoSxC0YZuVsJgzoHlNAtO5FxydI HJrMQ2X4Ja08uH65aGI8YSzooKxgKJUXxScKCNSWooXnXXx+oPxr4PnJ7VYol5/Wkm FpBO0NXoCZPSn+QKV4jCXaxKxSWpm6H6ANKFCDtqCHe/P4BG8MDuJy2ysBuzIwzEuQ tT3GOePu0sK/Ag7sGMl4kmLb4CNTtgZ/YQc/+ugkX58AJuEB+IMASjm+3n0aQf3wC2 9zYnKXDFn6NIwPCqPkn0hauuF6ibjVb0aDVfX0PGbjl/NFCkA50IU9drShtm49Nhnn GGF6Ch2b01EOg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sgjHp-005Yem-R6; Wed, 21 Aug 2024 12:13:57 +0100 Date: Wed, 21 Aug 2024 12:13:57 +0100 Message-ID: <86ikvuxh56.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Alexander Potapenko Subject: Re: [PATCH 04/12] KVM: arm64: Force GICv3 traps activa when no irqchip is configured on VHE In-Reply-To: References: <20240820100349.3544850-1-maz@kernel.org> <20240820100349.3544850-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, glider@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_041403_380221_4B0E60A8 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 21 Aug 2024 00:33:40 +0100, Oliver Upton wrote: > > s/activa/active/ > > On Tue, Aug 20, 2024 at 11:03:41AM +0100, Marc Zyngier wrote: > > On a VHE system, no GICv3 traps get configured when no irqchip is > > present. This is not quite matching the "no GICv3" semantics that > > we want to present. > > > > Force such traps to be configured in this case. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/vgic/vgic.c | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c > > index 974849ea7101..2caa64415ff3 100644 > > --- a/arch/arm64/kvm/vgic/vgic.c > > +++ b/arch/arm64/kvm/vgic/vgic.c > > @@ -917,10 +917,13 @@ void kvm_vgic_flush_hwstate(struct kvm_vcpu *vcpu) > > > > void kvm_vgic_load(struct kvm_vcpu *vcpu) > > { > > - if (unlikely(!vgic_initialized(vcpu->kvm))) > > + if (unlikely(!irqchip_in_kernel(vcpu->kvm) || !vgic_initialized(vcpu->kvm))) { > > Doesn't !vgic_initialized(vcpu->kvm) also cover the case of no irqchip > in kernel? It does, but that's purely accidental. I can drop that, but it is really fragile. Thanks, M. -- Without deviation from the norm, progress is not possible.