From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1183CC3DA5D for ; Fri, 19 Jul 2024 07:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AH3Vhst81G9d1Hmgb//s5HMIgrQrOhGS8U8OfcfB82k=; b=lL9I1MpoK58OvBfW4JcnxsJqt5 CokcdMQqrFDUvH1KrT618F1b5NyhlZoBHtVNqBJa4NOdU1++SAY83lGoTZ7WaVmnKvS678H1YNDVa fo8FWEOv9BAI1ABcK+3JiGsqcR0F5ShVbkaAmeIZg/J7DdX5gcw89lh6wjVJDmtzY0VFjn8GM5jza NVRdUSnnCsIH14VgeOLg/H3rqIFVcRrPTVc5AsULCJZz0QovLMqtjlArg7/uWpniK/nipC6wq+Wq7 czyl9d6zsqntHeFb1XMty1Ra24houHGRc5qgDOehWJdw8Mqb3mcivHLnzt4Oqg5WPC4b5xmnIoHnA 71G4eGmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUiTL-00000001yQe-3eBz; Fri, 19 Jul 2024 07:56:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUiSr-00000001yJG-2NUd for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2024 07:55:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4A5A261C4E; Fri, 19 Jul 2024 07:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1038C32782; Fri, 19 Jul 2024 07:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721375740; bh=6Ay4p6jJCBni9LRzuGT1socEKkaxV4GanP/ZK2W/s/k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mD9d6Un588NMRY1s1nwglMIEvLYOQdfQuvFjOLyw+e3BbuDaEHoznlFOY8BTFG9x+ XlrNqf6L7MPwF1P0I2qHmWWn2to9Nd8NIalDngtAfJv8YBomn04yaJYclcjfDqXbY5 LzFSu3pEZlnDUaXHSrO61rxhk6qEBmPcrQxwn70+UV4li4O4Hu0Bbf9mdUA9cOvvwx q2RYEdBmApwd+rUdqSrW9NnCh9q60H/3qbRWI4z/k1oGzOhcEVRMKHYXgdRPmxXdBK /tp1QQmT2AF0QQsjI96XB074W12Nuwy/k1r1/4oQB/2Fkudye/bdOzMuBpOQMFYpoN UYc27cbUrUMhw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sUiSn-00De84-D8; Fri, 19 Jul 2024 08:55:37 +0100 Date: Fri, 19 Jul 2024 08:55:37 +0100 Message-ID: <86ikx13jeu.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Catalin Marinas , Will Deacon , Mark Brown , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] arm64/sysreg: Correct the values for GICv4.1 In-Reply-To: <20240718215532.616447-1-rananta@google.com> References: <20240718215532.616447-1-rananta@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_005541_680553_E023FA24 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 Jul 2024 22:55:32 +0100, Raghavendra Rao Ananta wrote: > > Currently, sysreg has value as 0b0010 for the presence of GICv4.1 in > ID_PFR1_EL1 and ID_AA64PFR0_EL1, instead of 0b0011 as per ARM ARM. > Hence, correct them to reflect ARM ARM. > > Signed-off-by: Raghavendra Rao Ananta > --- > arch/arm64/tools/sysreg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index a4c1dd4741a47..7ceaa1e0b4bc2 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -149,7 +149,7 @@ Res0 63:32 > UnsignedEnum 31:28 GIC > 0b0000 NI > 0b0001 GICv3 > - 0b0010 GICv4p1 > + 0b0011 GICv4p1 > EndEnum > UnsignedEnum 27:24 Virt_frac > 0b0000 NI > @@ -903,7 +903,7 @@ EndEnum > UnsignedEnum 27:24 GIC > 0b0000 NI > 0b0001 IMP > - 0b0010 V4P1 > + 0b0011 V4P1 I wonder why we have different naming schemes for the same feature... > EndEnum > SignedEnum 23:20 AdvSIMD > 0b0000 IMP > Yup, this looks correct and checks out against revision H.b of the GICv3 spec, revision K.a of the ARM ARM, and even I.a (which the original patches were referencing). Once more, it shows that these dumps should be automatically generated from the XML instead of (creatively) hand-written. Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.