From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53B2CD4F5E for ; Thu, 21 May 2026 10:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qfM82z3BHmVFU110xOhDnN73f2JicISYXk83H5AhObU=; b=O+bez703gEKNZaPxuUggnxa4oa PQ34444stcgV/Rk22N3REw6034K2E0SwIWGbqVlPZJf8OHElHqokeXvc11Gqsw8lFKzyv2eeH4xAb SdgUAmZDmuDSp4ENY+LXGWJMVAcWUpNp7XqRgIOPBIqbfBf4nMGYifUb8vU3zFnrxZUyzUIMcZblB YJDdPc1zn3IWxw7/skStT37w5UnMajqDFrt57zrPdxyZBSpgp1OzP/BaXWwnsXuJkNInGLHR9Hu91 XFQsvxmEzNSREer0oI3V4PxLuoJERqBGkkjWR8PKBlF2nfU9KQ0w9pqk7jC/1aJ/at9pBFIPXHqoD 32/Aj7IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ0Ub-00000007RBu-24RO; Thu, 21 May 2026 10:19:05 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ0Ua-00000007RBN-2mw0 for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2026 10:19:04 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1F824601F4; Thu, 21 May 2026 10:19:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97EA1F000E9; Thu, 21 May 2026 10:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779358743; bh=qfM82z3BHmVFU110xOhDnN73f2JicISYXk83H5AhObU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LlzMutfvy8MAr6JgeXqIIc7RUQZwsc04MN6EdMvWVRty5YTkiehbKFfqqw37+6iga gJoMLV5OWS4O2EwwOVt2hDqaJijKSfg/KrPA35M05IKt6CwQsrjWJSyg0gds0m9nFi fya7uX2xCr85GIG7VpStByHEXh8nQYUoazks2wd5HbDkUrKeEQkSSETALSSVG+KcyI ctcJVxRxPE12NzuFW0bqG5y5ZH62RRH/3yYv7f6ACq7lYn6Syoy981s+MCfEVEreKr kY7Jyif//GoEqyhigpXFA1hvMUGG9DNklgbwYJDFCTT/CSlGydS5VJe10w0c79aQax rbZPGuMoV3g/Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wQ0UX-00000004liO-2gGN; Thu, 21 May 2026 10:19:01 +0000 Date: Thu, 21 May 2026 11:19:01 +0100 Message-ID: <86jysxvze2.wl-maz@kernel.org> From: Marc Zyngier To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Suzuki K Poulose , Catalin Marinas , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com Subject: Re: [PATCH v14 01/44] kvm: arm64: Include kvm_emulate.h in kvm/arm_psci.h In-Reply-To: <20260513131757.116630-2-steven.price@arm.com> References: <20260513131757.116630-1-steven.price@arm.com> <20260513131757.116630-2-steven.price@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: steven.price@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, joey.gouly@arm.com, alexandru.elisei@arm.com, christoffer.dall@arm.com, tabba@google.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, gshan@redhat.com, sdonthineni@nvidia.com, alpergun@google.com, aneesh.kumar@kernel.org, fj0570is@fujitsu.com, vannapurve@google.com, WeiLin.Chang@arm.com, Lorenzo.Pieralisi2@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 13 May 2026 14:17:09 +0100, Steven Price wrote: >=20 > From: Suzuki K Poulose >=20 > Fix a potential build error (like below, when asm/kvm_emulate.h gets > included after the kvm/arm_psci.h) by including the missing header file > in kvm/arm_psci.h: >=20 > ./include/kvm/arm_psci.h: In function =E2=80=98kvm_psci_version=E2=80=99: > ./include/kvm/arm_psci.h:29:13: error: implicit declaration of function > =E2=80=98vcpu_has_feature=E2=80=99; did you mean =E2=80=98cpu_have_fea= ture=E2=80=99? [-Werror=3Dimplicit-function-declaration] > 29 | if (vcpu_has_feature(vcpu, KVM_ARM_VCPU_PSCI_0_2)) { > | ^~~~~~~~~~~~~~~~ > | cpu_have_feature >=20 > Reviewed-by: Gavin Shan > Signed-off-by: Suzuki K Poulose > Signed-off-by: Steven Price Unrelated to this patch, but really easy to fix: the standard prefix for patches targeting KVM/arm64 is: "KVM: arm64: [opt subsys:] Something starting with a capital letter" where "opt subsys" could be "CCA" where applicable. It'd be good to have some consistency. Thanks, M. --=20 Without deviation from the norm, progress is not possible.