From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02D9FF3D332 for ; Thu, 5 Mar 2026 16:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gZVs978fG63IeYkIm4zIOuQhCCjaFcz+rYiA+0VxTTc=; b=IfP0Dwxiq+Agv6AFs8fwp1nsVi qBpX7F9cmQcJPT0E5TKVUlrcq1sw7pLUGpD5Z0QO++5iCU2GW7J3yqSuE/FtvR8/vW/WVm/LMJao5 jDme26HhKvE+bZhhFHhnVbADJBp6Oof6mWGalj5+JGQPvzT8+hQLdiSkHUm0prrRk+D0cvrm8GbSe CvlX4EzfPGkPXGvuif8RuWrLtG7jyyPc6zqNB+e3okOS77LYeTB8Kx6mtjkEqTQLV2OjWgBFMKoiP PWzLT3M8RmF4FVwK7kE62j0ITWG8MGXurl+BuGmp477yLSodzf1EkD/xZkokc7N1WIROzGPKoRsDT YTGVljFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyBvZ-00000002EZQ-3eD9; Thu, 05 Mar 2026 16:51:57 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyBvX-00000002EZ4-16vW for linux-arm-kernel@lists.infradead.org; Thu, 05 Mar 2026 16:51:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7531F43746; Thu, 5 Mar 2026 16:51:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBE0C116C6; Thu, 5 Mar 2026 16:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772729514; bh=oqOA+tmfWR/3o3GnKvVmaJw8vJLjDXFAY6myXgfJMys=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=moM108plUmV/G37engsMy4GFUzqDGqzF8whhdWesfjVVbT9tInS7er92/tfDqURoY gXxTbux74YQ8hmfSphEl4EStZXsfKCcf71SmOC8x+Nw+dSDC0PICKSTecz2LBipClb s+TNSV7lh9WrMhuMLRORHcA0Rr9+mPCJ3Fez0/yv6Rh4HkpkNyB68CbwwtkS4fhAI+ SiY7qXk+y1cHJojCDdzAEFIBjxc7+fugCsgW6JoeGn434ltkjapK49/fwFPExJYJVm oit1Cd8WYK1oY320OGkhtkjftPZxwn3k2A/jg7tZ5m8lUK6UHeEaJb75pYtTHq1XWw 2TMtsFYZxG9jw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vyBvU-0000000GXE2-0TSs; Thu, 05 Mar 2026 16:51:52 +0000 Date: Thu, 05 Mar 2026 16:51:51 +0000 Message-ID: <86jyvq6wyg.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yangyicong@hisilicon.com, wangzhou1@hisilicon.com Subject: Re: [PATCH v1 0/2] KVM: arm64: Fix a couple of latent bugs in user_mem_abort() In-Reply-To: <20260304162222.836152-1-tabba@google.com> References: <20260304162222.836152-1-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, yangyicong@hisilicon.com, wangzhou1@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260305_085155_323663_FA590A6E X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 04 Mar 2026 16:22:20 +0000, Fuad Tabba wrote: > > Finding these issues just reinforces how fragile this 300-line function > has become. We really need to refactor it to make the state flow easier > to reason about. I'm currently putting together a series to do just that > (introducing a proper fault state object), so stay tuned for an RFC on > that front. If you have such patches, please post them sooner rather than later, even if the rework is incomplete. I'd be happy take small patches that start add infrastructure early and work out the full refactoring over time. Thanks, M. -- Without deviation from the norm, progress is not possible.