Re: [PATCH] KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list

[Marc Zyngier <maz@kernel.org>]

On Thu, 01 Aug 2024 20:14:38 +0100,
Mark Brown <broonie@kernel.org> wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Thu, Aug 01, 2024 at 05:45:49PM +0100, Marc Zyngier wrote:
> 
> > Can we please switch all this stuff to symbolic naming instead of
> > magic numbers? Given how much effort is going into the "automated
> > generation" thing, it is mind-boggling that the tests still rely on
> > handcrafted numbers. We just end-up with two different sets of bugs.
> 
> > At the moment, the level of confidence I have in this stuff is
> > sub-zero.
> 
> Yeah, I was wondering why this wasn't using the generated values
> especially given that the generated headers are available to tools - I
> wasn't sure if this was a deliberate decision to cross check the data
> entry or something.

We've lost that battle a long time ago, given the numbers of bugs the
sysreg file has had. The real reason is that the ABI reports the
encoding, and that it is rather easy to just dump stuff back into the
test using the script described in the very first commit for the test.

Also, the test predates the generated stuff by some margin.

> I'd certainly be happy to convert, though that does
> seem a bit invasive for a fix.

Not for a point fix, for sure. And if you do, make sure it is entirely
scripted.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.