From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5A62C4828F for ; Thu, 8 Feb 2024 12:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XPXQziYrUTmImvEhqOrYHlXG7JZ3WYHZgpx8iVZ/Roo=; b=f/NfXAHd8WSvbh s/9Xro0FD6ZXQp8UV5WbHPbCxEki6RVTd+7ggswiK0kaCtlo/PNZbH0PjSfbMY3hF0i+BOXOQJHAs suJ3A5+XzSWtOEwIH9s6M0Q4GRVXnhybgKoXkZxLJhqpi1qdZXS+du2RNgWqtNl26bJORFjKUeOz9 YTZ0qcMlsYM10erzmvsYVlJdLGnsP0aTMBGWzxtE6jzhS+eYrh/L17E6RCBlWcvfSxuzWJ5c+JjSv 67VJb4+ye8k35//7IzY3pL0zchX6bpq+I/OnPGOt0LNh6zzvIeVgKZAchwUYDFdH90jFkaowRodqa CsPwjJFseW3x7w6d/eXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY3jd-0000000DlKE-2sr6; Thu, 08 Feb 2024 12:42:33 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY3jb-0000000DlJq-0xTg for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 12:42:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 20A2BCE1B16; Thu, 8 Feb 2024 12:42:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 562ADC433C7; Thu, 8 Feb 2024 12:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707396148; bh=XH+U5pCeF3OWttf2d9rJ1nyXW8JKsT0N/UnkhwonW1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TcNbwS23goo6KZCZW9rdFa9bUHUaTutT2RLLRqNf2lfGsME3/EjksFG0wgZD8ktee KDH84LFsb7JWSxh8DxKyjZGFTOFJbahr7GeBaVQzUBUDX6zWKkSorju1Epq1t+dXBa gSDtpRpRlsugInSPCqq6qqh42ZRL1wDv3SJhYXY1DP8pVHYjFbP5QatY0NaT2dNdKH Aiet52UBqzI/ae777oQKHPMRgXGEzgan6V3VsJT3sLkbhlOgeQaiSJ4qVo+t8kuNfr XCvAgqpk7tK22AJKvXpxwDWqZhZfz2/FCFgaQTcVMCkh8D+qP2TVqSPshkmNujiLuc Q3/IFCJdVDWzg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rY3jV-001RO3-Uq; Thu, 08 Feb 2024 12:42:26 +0000 Date: Thu, 08 Feb 2024 12:42:25 +0000 Message-ID: <86jznf5dqm.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: kvmarm@lists.linux.dev, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v1 2/2] KVM: arm64: removed unused kern_hyp_va asm macro In-Reply-To: <20240208105422.3444159-3-joey.gouly@arm.com> References: <20240208105422.3444159-1-joey.gouly@arm.com> <20240208105422.3444159-3-joey.gouly@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, kvmarm@lists.linux.dev, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_044231_463306_A6B54FD1 X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 08 Feb 2024 10:54:22 +0000, Joey Gouly wrote: > > The last usage of this macro was removed in: > commit 5dc33bd199ca ("KVM: arm64: nVHE: Pass pointers consistently to hyp-init") > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > --- > arch/arm64/include/asm/kvm_mmu.h | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h > index d248a7ae627a..961d4431654b 100644 > --- a/arch/arm64/include/asm/kvm_mmu.h > +++ b/arch/arm64/include/asm/kvm_mmu.h > @@ -53,27 +53,6 @@ > > #include > > -/* > - * Convert a kernel VA into a HYP VA. > - * reg: VA to be converted. > - * > - * The actual code generation takes place in kvm_update_va_mask, and > - * the instructions below are only there to reserve the space and > - * perform the register allocation (kvm_update_va_mask uses the > - * specific registers encoded in the instructions). Consider moving this comment to the C version instead of deleting it completely (the part about the register allocation is pretty crucial). Oliver can probably fix this when applying it, and my previous Ack still stands. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel