From: Marc Zyngier <maz@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Zaid Al-Bassam <zalbassam@google.com>,
Reiji Watanabe <reijiw@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] arm64/arm: arm_pmuv3: perf: Don't truncate 64-bit registers
Date: Fri, 03 Nov 2023 18:18:03 +0000 [thread overview]
Message-ID: <86jzqy1z1g.wl-maz@kernel.org> (raw)
In-Reply-To: <6281f889-d665-451b-a864-e2751fce8017@arm.com>
On Fri, 03 Nov 2023 06:09:36 +0000,
Anshuman Khandual <anshuman.khandual@arm.com> wrote:
>
>
>
> On 11/3/23 00:00, Ilkka Koskinen wrote:
> > The driver used to truncate several 64-bit registers such as PMCEID[n]
> > registers used to describe whether architectural and microarchitectural
> > events in range 0x4000-0x401f exist. Due to discarding the bits, the
> > driver made the events invisible, even if they existed.
> >
> > Moreover, PMCCFILTR and PMCR registers have additional bits in the upper
> > 32 bits. This patch makes them available although they aren't currently
> > used. Finally, functions handling PMXEVCNTR and PMXEVTYPER registers are
> > removed as they not being used at all.
> >
> > Fixes: df29ddf4f04b ("arm64: perf: Abstract system register accesses away")
> > Reported-by: Carl Worth <carl@os.amperecomputing.com>
>
> This needs an URL for the original bug report in the following format.
>
> Reported-by: Carl Worth <carl@os.amperecomputing.com>
> Closes: https://lore.kernel.org/..
A report is not necessarily done in a public list. And yet there is *a
lot* of value in recognising the reporter of the bug.
>
> Otherwise, the following checkpatch warning shows up.
>
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #17:
> Reported-by: Carl Worth <carl@os.amperecomputing.com>
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Checkpatch can say what it wants, but that doesn't make it true.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-03 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 18:30 [PATCH v3] arm64/arm: arm_pmuv3: perf: Don't truncate 64-bit registers Ilkka Koskinen
2023-11-03 6:09 ` Anshuman Khandual
2023-11-03 18:18 ` Marc Zyngier [this message]
2023-11-06 5:55 ` Ilkka Koskinen
2023-11-07 10:55 ` Will Deacon
2023-11-07 14:18 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzqy1z1g.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=geert+renesas@glider.be \
--cc=ilkka@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=reijiw@google.com \
--cc=will@kernel.org \
--cc=zalbassam@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).