From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67F28C4332F for ; Fri, 3 Nov 2023 18:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1jpgxT5UmzXlxJ1z3j0O8g4o0JCUfDi/b+UR4UBGmaw=; b=mNLHnaKvKnSpFM LV2JrSgDtlAiTtqX4l7u/rOZV9zb9IwDZDutN8oWJ4hOTnF9O/nHAQBlTGpAM/cWZrxHXA4GAH8Oh SPlgOzUgrFrleIax/EOpj7q2vzT4iYxg/6uM4oiLGft4ABR7A2obDutPWVkmoIwoVpS+csTepW3Rm sj5D+ng/+PV5i7UOb55F4xo8yHTrdcD1Rq6dSB2u5b4eHROPDJ2KkJov4ghvBASiVqqo53gjerz59 KhIcyn5+Vi9fhzJXefP+oU1MORDbU6g4YHqepnSro5138vxq3Ebif+/K04lRyanKbTeEInEGwOJeq qSFIwJkmIj0JfWqD23vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyykM-00BxCb-2N; Fri, 03 Nov 2023 18:18:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyykF-00BxBs-2J for linux-arm-kernel@lists.infradead.org; Fri, 03 Nov 2023 18:18:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 401E26160D; Fri, 3 Nov 2023 18:18:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC99CC433C8; Fri, 3 Nov 2023 18:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699035486; bh=Vv2BzD6Qexx4MM71nUzIiw7gw6YGMBr1uKIdCdtJuxA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bR14jeR1WHWrI+mdJMSyVL0HWekvav8rzkAfIoPXcnw5X1WXI++n0S5jlRFR5mQXH D8cLm9m+2J1tK54h7ng6fOCxHqdA/ue3PFvz7iWKTGR0pUlLeYfitSQgZqXIqkagF1 wSdg9DK1fuQ7/beT6NiaUMHfdlKE/+BE6PHvjm86zBRZB0x7ZrpJQNpKWEZXIhxpZo VMehdkT32/GcvtFU9gzU2UXuwkC0n8SE7MqIYoWFxiZtRMdDZ7QgBBw+JR4vlwF2xK 9sU5zRZk61IRuszkacB1ZR4ZRTDiHp7WP3urZX3rYjW/PDJ0rybmOxIel18kW5UdVw jMxkv9h3rNh7A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qyyk8-00A91L-GI; Fri, 03 Nov 2023 18:18:04 +0000 Date: Fri, 03 Nov 2023 18:18:03 +0000 Message-ID: <86jzqy1z1g.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: Ilkka Koskinen , Mark Rutland , Catalin Marinas , Will Deacon , Zaid Al-Bassam , Reiji Watanabe , Geert Uytterhoeven , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] arm64/arm: arm_pmuv3: perf: Don't truncate 64-bit registers In-Reply-To: <6281f889-d665-451b-a864-e2751fce8017@arm.com> References: <20231102183012.1251410-1-ilkka@os.amperecomputing.com> <6281f889-d665-451b-a864-e2751fce8017@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, ilkka@os.amperecomputing.com, mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org, zalbassam@google.com, reijiw@google.com, geert+renesas@glider.be, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231103_111811_921768_55F95447 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 03 Nov 2023 06:09:36 +0000, Anshuman Khandual wrote: > > > > On 11/3/23 00:00, Ilkka Koskinen wrote: > > The driver used to truncate several 64-bit registers such as PMCEID[n] > > registers used to describe whether architectural and microarchitectural > > events in range 0x4000-0x401f exist. Due to discarding the bits, the > > driver made the events invisible, even if they existed. > > > > Moreover, PMCCFILTR and PMCR registers have additional bits in the upper > > 32 bits. This patch makes them available although they aren't currently > > used. Finally, functions handling PMXEVCNTR and PMXEVTYPER registers are > > removed as they not being used at all. > > > > Fixes: df29ddf4f04b ("arm64: perf: Abstract system register accesses away") > > Reported-by: Carl Worth > > This needs an URL for the original bug report in the following format. > > Reported-by: Carl Worth > Closes: https://lore.kernel.org/.. A report is not necessarily done in a public list. And yet there is *a lot* of value in recognising the reporter of the bug. > > Otherwise, the following checkpatch warning shows up. > > WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report > #17: > Reported-by: Carl Worth > Signed-off-by: Ilkka Koskinen Checkpatch can say what it wants, but that doesn't make it true. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel