From: Marc Zyngier <maz@kernel.org>
To: Nianyao Tang <tangnianyao@huawei.com>
Cc: <tglx@linutronix.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <guoyang2@huawei.com>,
<wangwudi@hisilicon.com>, <wangzhou1@hisilicon.com>
Subject: Re: [PATCH v3] irqchip/gic-v4.1: Use local 4_1 ITS to generate VSGI
Date: Thu, 15 May 2025 08:16:25 +0100 [thread overview]
Message-ID: <86ldqyfinq.wl-maz@kernel.org> (raw)
In-Reply-To: <20250515145359.2795959-1-tangnianyao@huawei.com>
On Thu, 15 May 2025 15:53:59 +0100,
Nianyao Tang <tangnianyao@huawei.com> wrote:
>
> On multi-node GICv4.1 system, VSGI senders always use one certain 4_1 ITS,
> because find_4_1_its return the first its_node in list, regardless of
> which node the VSGI sender is on. This brings guest vsgi performance drop
> when VM is not running on the same node as this returned ITS.
>
> On a 2-socket environment, each with one ITS and 32 cpu, GICv4.1 enabled,
> 4U8G guest, 4 vcpu is running on same socket.
> When VM on socket0, kvm-unit-tests ipi_hw result is 850ns.
> When VM on socket1, it is 750ns. The reason is VSGI sender always
> use the last reported ITS(that on socket1) to inject VSGI. The access
> from cpu to other-socket ITS will cost 100ns more compared to cpu to
> local ITS.
>
> By using a local ITS, we can get 12% reduction in IPI latency.
>
> Modify find_4_1_its to first return per-cpu local_4_1_its, which is
> init when inherit the VPE table from the ITS or from another CPU.
> If fail to find local 4_1 ITS, return any 4_1 ITS like before.
>
> Signed-off-by: Nianyao Tang <tangnianyao@huawei.com>
> Suggested-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/87tthgrt7s.wl-maz@kernel.org
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2025-05-15 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 14:53 [PATCH v3] irqchip/gic-v4.1: Use local 4_1 ITS to generate VSGI Nianyao Tang
2025-05-15 7:16 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ldqyfinq.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=guoyang2@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangnianyao@huawei.com \
--cc=tglx@linutronix.de \
--cc=wangwudi@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).