From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52457C52D7C for ; Wed, 21 Aug 2024 11:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2T3WJEnWX64i+fUIbdW1At2x7+fOT6NYLwQsjQAk8yE=; b=teMrYjcBm68+8/+ykTPn5GdBxt +Emnc0ZEq1uk3EpUt3FD/1rILRvIw1ax7H8Zhqn2m3muaQtw3YZQNxtp8SDtl8tq7XfImxxwrncj6 73pVWLr62yvzdfNn3aobkTyyrEdgAMReB/t258s/G7aUDWHpwN5QnVhbhOnV+KOKkkhTrj8jG5L9K xGKJnTaokv+tJ6yYHbktPbSpklfNoa/t8upzlKXIgGk0giJVDkVOyINYWfMjeAR4kBi6gsEuYyd21 rJwcCijOy560sQZ5S/j/KSMd5ilfjFhoYLaJ8L4qf7JEdchrf1HFEsqVExmEkNRTw6099v0k9vKS1 a2aoIN3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgjAx-00000008aCh-1zhy; Wed, 21 Aug 2024 11:06:51 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgj4I-00000008XVJ-17dV for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 11:00:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 83CF0CE0E1A; Wed, 21 Aug 2024 10:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A9E0C4AF0C; Wed, 21 Aug 2024 10:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724237995; bh=oG3C/CyEhEg8t+4o65Fl/gjP36ABhhIxycBx70x7ZH8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CFUdtImvk8zS41kpFawufI6p4JNkgaHn5CMkgARWa4eIdl/F0mEWRMSgGJvnUF3Ml 0esBag33idw/qWD+W40FjGSH8+8Sfk7NJFkbh0zuA15k07uFu30JGlMee86Hf+UqUy BrbmUg1bsrpabAt9ktKw3y+h+hyW05Z5h6750luRf0gmb0TmRaHJgh8nu/9320KKMb +2CxKHvpk3Nk4rGh51B9ROhB/nmWPYCTjFgwN147Z32uMDxwiI+7K2DjxRup/hG7G/ bgrlu826uk5P64OejOaJusJddyJUAd6EFLQ28Ed8igCSRJs28oVqVZg05iNEh3+mRV iBRe0IoFg0mnQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sgj4D-005YAo-3D; Wed, 21 Aug 2024 11:59:53 +0100 Date: Wed, 21 Aug 2024 11:59:52 +0100 Message-ID: <86le0qxhsn.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Alexander Potapenko , stable@vger.kernel.org Subject: Re: [PATCH 01/12] KVM: arm64: Make ICC_*SGI*_EL1 undef in the absence of a vGICv3 In-Reply-To: References: <20240820100349.3544850-1-maz@kernel.org> <20240820100349.3544850-2-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, glider@google.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_035958_604942_DE6840E5 X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Aug 2024 22:46:30 +0100, Oliver Upton wrote: > > On Tue, Aug 20, 2024 at 11:03:38AM +0100, Marc Zyngier wrote: > > On a system with a GICv3, if a guest hasn't been configured with > > GICv3 and that the host is not capable of GICv2 emulation, > > a write to any of the ICC_*SGI*_EL1 registers is trapped to EL2. > > > > We therefore try to emulate the SGI access, only to hit a NULL > > pointer as no private interrupt is allocated (no GIC, remember?). > > > > The obvious fix is to give the guest what it deserves, in the > > shape of a UNDEF exception. > > > > Reported-by: Alexander Potapenko > > Signed-off-by: Marc Zyngier > > Cc: stable@vger.kernel.org > > LGTM, and just as an FYI I do plan on grabbing this for 6.11 Great, thanks. Are you planning to route this via arm64, given that Paolo is away for a bit? M. -- Without deviation from the norm, progress is not possible.