From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE746C27C4F for ; Sat, 15 Jun 2024 17:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=udL50IFtxkL3n2dI0ZOGClli0fO+RCGGdJ828jTPTaI=; b=V88O3LIekSXH9oy0aFolBoXvo3 MOUV33KiLFFTPyTZ2HYrWw1zph8TulnqE7ZqPwfyTOHf3e5kUzAxd+B3l7Pom9u8Mn4WJUK9yuXCz 29ess8HA883hwvZTrI9+MVc70ODl6DhAbaYdUmTvrjQek8a+UIhGsldzvNwYKbMoW6/nhAbbqX9SY 2zEXLsEF1Jor0w8sAUUPFC93tzrb9pRAyP/sltbbAvX87ja5Sdo9+buCXy4OtlQM6jUARls6251Sv QhF72qIpMk6E5Fc9coLhgbwVa3/tDJPPcbPC+pwcSThpHS1zXLjahb4t3qQSqcYq6FlQOY9N8//Xx Zs0yVgsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIX8S-00000005qAD-26Bt; Sat, 15 Jun 2024 17:24:16 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIX8P-00000005q8i-145b for linux-arm-kernel@lists.infradead.org; Sat, 15 Jun 2024 17:24:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 53957CE065A; Sat, 15 Jun 2024 17:24:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A31EEC116B1; Sat, 15 Jun 2024 17:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718472248; bh=le7fDVc9cjR9e9+nug6jndZDflrnZEi5eYgU/1s8wqg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hP2DLm/deqsXgPgT38e0Sodakqx1XB9uSIkp+W1LvraGoXryG7Mo/akJfqX4dSYcS +ATbnQ37NuniAmmPQo5Zo8i3sX7DhcgaY35+DL1djBwlQNvi1Qhp0RIJCnCeienFrg 5Z3rdzR9Juk/XYPnwItncDZfx/x1O9OvbZMXyIldZT4AZqjVQpZ9eDsY1f0ytvu3ID veeW2KTjWb9F+2hryME7cDN6Beq2oGMTJR3O/ALBE59GGLBSn/+J4lWRwSasLpgDsh IR1Mp3lPt/Kuy01kWcAe86wJZLjYDP2r287w1gWAA4+l36bOGfA24HpGx4iA5A0B1i rS+vCyTrRJzFA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sIX8H-004BDN-PL; Sat, 15 Jun 2024 18:24:05 +0100 Date: Sat, 15 Jun 2024 18:24:05 +0100 Message-ID: <86le36jf0q.wl-maz@kernel.org> From: Marc Zyngier To: Shivamurthy Shastri Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, tglx@linutronix.de, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics In-Reply-To: <20240614102403.13610-15-shivamurthy.shastri@linutronix.de> References: <20240614102403.13610-1-shivamurthy.shastri@linutronix.de> <20240614102403.13610-15-shivamurthy.shastri@linutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shivamurthy.shastri@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, tglx@linutronix.de, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240615_102413_720601_620AAEDB X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 14 Jun 2024 11:23:53 +0100, Shivamurthy Shastri wrote: > > From: Thomas Gleixner > > Nothing builds a platform_device MSI domain for wire to MSI on top of > this. The "regular" users of the platform MSI domain just provide their own > irq_write_msi_msg() callback. > > Signed-off-by: Thomas Gleixner > Signed-off-by: Anna-Maria Behnsen > Signed-off-by: Shivamurthy Shastri > Cc: Thomas Gleixner > Cc: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-mbi.c | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c > index dbb8b1efda44..19298cc6c2ee 100644 > --- a/drivers/irqchip/irq-gic-v3-mbi.c > +++ b/drivers/irqchip/irq-gic-v3-mbi.c > @@ -199,31 +199,16 @@ static int mbi_allocate_pci_domain(struct irq_domain *nexus_domain, > } > #endif > > -static void mbi_compose_mbi_msg(struct irq_data *data, struct msi_msg *msg) > -{ > - mbi_compose_msi_msg(data, msg); > - > - msg[1].address_hi = upper_32_bits(mbi_phys_base + GICD_CLRSPI_NSR); > - msg[1].address_lo = lower_32_bits(mbi_phys_base + GICD_CLRSPI_NSR); > - msg[1].data = data->parent_data->hwirq; > - > - iommu_dma_compose_msi_msg(irq_data_get_msi_desc(data), &msg[1]); > -} > - > /* Platform-MSI specific irqchip */ > static struct irq_chip mbi_pmsi_irq_chip = { > .name = "pMSI", > - .irq_set_type = irq_chip_set_type_parent, > - .irq_compose_msi_msg = mbi_compose_mbi_msg, > - .flags = IRQCHIP_SUPPORTS_LEVEL_MSI, > }; > > static struct msi_domain_ops mbi_pmsi_ops = { > }; > > static struct msi_domain_info mbi_pmsi_domain_info = { > - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_LEVEL_CAPABLE), > + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), > .ops = &mbi_pmsi_ops, > .chip = &mbi_pmsi_irq_chip, > }; This patch doesn't do what it says. It simply kills any form of level MSI support for *endpoints*, and has nothing to do with any sort of "wire to MSI". What replaces it? M. -- Without deviation from the norm, progress is not possible.