From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DE24C61D9B for ; Wed, 22 Nov 2023 09:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2u8IedJJa7k8vIctSWh14+yL5D9hh9GDokNlxXJuom0=; b=zRlVOrpWoakPOS hMurRHAeiq0kArsZj7kUCFfSlpWcaOiExYmF52+YtPdaKrojSyOJkowbRSRjxP67ZMxXJBEblwhJ1 abgoW4EOfRBUPxx1bZW+4YR68CbERbZxjL6jPss/FMWhHbz4Qq2bEWPiRL0GcoDR4DDr8hDERLFAg MeVbdpU7KEC0j3pkH83isXGjF5PtomcYgxU9ELVcjaOvbZ3GTLRYJduSNXOUwSy3iMdo+ljG6ZiC/ ehj7qIAYWmxKU9tulSnexMnEEYMQIaPanuvCCngovI5J/B5e9LTJ29+fy3W9ffBDhEmQjGZTrrR/+ IW7Y+jy5d0xBaLnFB/Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5jpU-001JgM-0P; Wed, 22 Nov 2023 09:47:32 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5jog-001Iq0-1n for linux-arm-kernel@bombadil.infradead.org; Wed, 22 Nov 2023 09:46:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c4btlUL0CokLdpy4ZSEIsd/gdKgY3Mxs+vPD5cNMQzc=; b=nwHKoqv6z+re7yCMdkU6kqLw1H uAEuprX1ab1cHAVS8vIo4PLsIiFlm2eWg6voz5Zj4YQU7BvLeoqd1qlLg1FiUQltT+wIWA6ShL6gC WC7+aj0vFtV5UJJ9o8SQxROZOpLOeG6ofKnp3jOTlOXOPnmXhAuLTzGcNmEEbp6FQnJrcBEG1U3VZ CZkCerOtBPiwMEbVhBOYB/ezaWKocRvGG7Bw1rrMpIK3YvguSVm3Qqsfmm/DSjAkK1L608dlAubJj xuA6IL64Q9uWEW75Lee+r11591EIxvVNFCM1CrwWkuusHaJ8ptAlVQvX8LEz6kqOI4T4BMsxrFxw/ fCWGb+Sg==; Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5joc-00CGQQ-1P for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2023 09:46:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D120C61CD2; Wed, 22 Nov 2023 09:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F4B4C433D9; Wed, 22 Nov 2023 09:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700646393; bh=MCMS5v3jzmf+7lLA9wZaAGLJaz2gnrfEQNsqbXtQ994=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AqWdvnoT8BIgq72frVFNmSUx/EW9dfbieQNsKYmdNtFO+U6sj62DDF4YIafvbDiAF wVaLTXVUQApQ4uQPHDpWwDXNr3IFP9G/r+gm+RB5qakC1OWK8yK+g95ab6St8GaPE6 q1s+kFLGNK8LNYEO9HmKP6gMm1sUAP0uX/pFUjj4i5C1UsrUDdYa7dGNbHpCioK8tY 4XPDutRiM9Pc+8RZ9VMNmbAImvkc1DFlvwStS4MKRkRWpEXFva0jJdb3ECTt/AI/P8 l761J/TlUwCfdk74ux4Hg2bEBOU4obmgMi0BqRmcrHnGueAfLF1YPTNnJmBVOUT1es Yi1o/GsTAnxyw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r5joU-00FN8b-AW; Wed, 22 Nov 2023 09:46:30 +0000 Date: Wed, 22 Nov 2023 09:46:28 +0000 Message-ID: <86leaqyvbf.wl-maz@kernel.org> From: Marc Zyngier To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , James Morse , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v2 02/13] arm64: cpufeatures: Correctly handle signed values In-Reply-To: <2fb7398f-b865-44a7-8ee0-4a32ae40afa8@arm.com> References: <20231120123721.851738-1-maz@kernel.org> <20231120123721.851738-3-maz@kernel.org> <2fb7398f-b865-44a7-8ee0-4a32ae40afa8@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, ardb@kernel.org, james.morse@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_094638_790233_63890B98 X-CRM114-Status: GOOD ( 31.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Nov 2023 09:29:50 +0000, Suzuki K Poulose wrote: > > On 20/11/2023 12:37, Marc Zyngier wrote: > > Although we've had signed values for some features such as PMUv3 > > and FP, the code that handles the comparaison with some limit > > has a couple of annoying issues: > > > > - the min_field_value is always unsigned, meaning that we cannot > > easily compare it with a negative value > > > > - it is not possible to have a range of values, let alone a range > > of negative values > > > > Fix this by: > > > > - adding an upper limit to the comparison, defaulting to all bits > > being set to the maximum positive value > > > > - ensuring that the signess of the min and max values are taken into > > account > > > > A ARM64_CPUID_FIELDS_NEG() macro is provided for signed features, but > > nothing is using it yet. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/include/asm/cpufeature.h | 1 + > > arch/arm64/kernel/cpufeature.c | 66 +++++++++++++++++++++++++---- > > 2 files changed, 58 insertions(+), 9 deletions(-) > > > > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > > index f6d416fe49b0..5f3f62efebd5 100644 > > --- a/arch/arm64/include/asm/cpufeature.h > > +++ b/arch/arm64/include/asm/cpufeature.h > > @@ -363,6 +363,7 @@ struct arm64_cpu_capabilities { > > u8 field_pos; > > u8 field_width; > > u8 min_field_value; > > + u8 max_field_value; > > u8 hwcap_type; > > bool sign; > > unsigned long hwcap; > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index 646591c67e7a..e52d2c2b757f 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -140,12 +140,43 @@ void dump_cpu_features(void) > > pr_emerg("0x%*pb\n", ARM64_NCAPS, &system_cpucaps); > > } > > +#define __ARM64_EXPAND_RFV(reg, field, val) > > reg##_##field##_##val > > We have defined SYS_FIELD_VALUE to be the exact same thing in Patch 1 > and we later remove this and switch to using the same in Patch 8. > Could we not do this straight away here ? i.e. use the SYS_FIELD_VALUE > instead of adding this ? Because I'm a moron and updated everything *except* my own patches. Apologies for the noise, I'll fix that shortly. > Rest looks good to me. Thanks! M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel