From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 329CEC88E77 for ; Wed, 16 Sep 2026 07:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ijfOOZd0pqERrTuVYZCNeIuM97HHT4M3Ng/p5mLJTb8=; b=KmB+zK9tWk8gT0lGj1izzsnkZu Rhwy3HXvmjCCIx0Gca55fJKa9Dv8aJ9Enqb7tay2vgSfqRWexymJn6P0hsK81fRq+0Wzmy1uAE6Wr 1Pr1DE+J/xLvam2jA89E7/RhqZG6qLtUjt+bp7xPFMM8r8krP2+L0fyIuIxDGfcDV1pXDtxfto3T4 lb83gvTX1debewxJRyvOGx8Bq2+xYc4OGJTNUBLgZUEnid4DYTbb7keB9595ncMO7QpSrgTnTOSse 2Z2CCfHA0fA+zHOYAIHq1JcBYv9SYJWfT9hWs+WFA8BnjTfIv44e0dO8XrlHqAvhkl0oMJ1RX/icc Avdv7qSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jhS-00000008YJq-0XfT; Wed, 16 Sep 2026 07:04:58 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6jhR-00000008YJk-0CRQ for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2026 07:04:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 433D96020C; Wed, 16 Sep 2026 07:04:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB9D31F000FF; Wed, 16 Sep 2026 07:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789542296; bh=ijfOOZd0pqERrTuVYZCNeIuM97HHT4M3Ng/p5mLJTb8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Q4NP19SbuFICPDiwdiSSqrh0hVqa8/rRI63q89d6415EmMuU0T0GJ1vJfy9CI/z6T qOIIQ7rRPKuzkY3GSQCPO4paBLZHMrCzdfsALXiwBe5QaPJwG8e5kjOmXtmYTI/MXC m2XuuBk2g7HibnfcxmZFhNdCu4K9VfGVA/PMueG3XGFJ0Sym6f5hgNcTD6Azx2RIGU Dt8imczitPjeUG2YbF9gxHLsnVoEa9jbKP2Owu/Z3d8xYkWNCiDkqIFEqPnyekbs+4 AFq9akTLhAn9ID5JZkNEmajXvT4N2mmMbWoXoApIXWK61QJk9nwzNMa3cYvMA+PZNO 2U0YG2kIfOZ9w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x6jhN-00000009Tjo-2mC2; Wed, 16 Sep 2026 07:04:53 +0000 Date: Wed, 16 Sep 2026 08:04:53 +0100 Message-ID: <86mrth65ii.wl-maz@kernel.org> From: Marc Zyngier To: Itaru Kitayama Cc: Wei-Lin Chang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Wang Han , Shuai Xue , "Lorenzo Stoakes (ARM)" Subject: Re: [PATCH v6 0/7] KVM: arm64: nv: Implement nested stage-2 reverse map In-Reply-To: References: <20260915154305.3852871-1-weilin.chang@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: itaru.kitayama@fujitsu.com, weilin.chang@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, oupton@kernel.org, fuad.tabba@linux.dev, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, wanghan@linux.alibaba.com, xueshuai@linux.alibaba.com, ljs@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 16 Sep 2026 05:58:03 +0100, Itaru Kitayama wrote: > > Hi Wei-Lin, > > On Tue, Sep 15, 2026 at 04:42:58PM +0100, Wei-Lin Chang wrote: > > Hi, > > > > This is v6 of optimizing the shadow s2 mmu unmapping during MMU > > notifiers. > > > > This version fixes a few issues, and adds Marc's space optimization > > for kvm_guest_s2_mapping [1]. Please see the changelog for the details. > > > > Tested by booting L3, and running in-kernel targetted tests described > > in [2]. v5 got some tested-by's from Itaru and Wang (thanks), I didn't > > carry them over since some bugs fixed in v6 are non-obvious. Some > > retest would be much appreciated! > > > > Series based on v7.3-rc3 + Marc's nested mmu lifecycle fixes [3]. > > Observed on QEMU (accel tcg) only, but I saw: > > [ 1812.052752] BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1630 > [ 1812.052896] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 596, name: shadow_stage2 > > The kernel is built on top of Marc's fix and your version six series, but > the fix for debugfs will be posted later? > > Your hello_nested and shadow_stage2 ran without an issue. > > Tested-by: Itaru Kitayama So you have established that there is a critical locking bug, make sure you don't communicate any information to help narrow where that bug is, and yet give your Tested-by: tag? What is the point? I'm baffled. Can you at least provide an indication of what you did to get there as well as the full backtrace? M. -- Without deviation from the norm, progress is not possible.