From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1178CED63D for ; Tue, 18 Nov 2025 19:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D7hZa3rWcI5gxK129jZ7x7Z89DC+Zf/b1QIhDr2kfU4=; b=BI1z+NRt2vJBzCr2qpWIjISyHC jVZ+x/gnx9BQ6diI5tHzQAvA/Kjcc3+VYHTR2nWybQhJfgtXO65xzy1j903M36yDMv1PJqO1C0fMT 0/JCAl5uEcyZk0fDTtcrvA/vvm0IP8A7Ey5DPLfEcaBrym1n7FzoQJYAllo7rWtB9MiQyhpGk7SMo rzSX7kVhf/sa5qPVWJTlH26n3acnvuriW91Ic1pyvg8e/rG5iLAUstJ1mcUPWSS5CSmobLve+5MKL Qm72MG3O+Jh/Z8zjgNQRIy3rXWIxlR9VMUpmIPtOcr5V7RmNLVT7dY60NLmwvi08ZXkMRgzt93Ku8 5ypm9nvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLR2P-000000010Gn-0rEt; Tue, 18 Nov 2025 19:06:49 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLR2M-000000010GD-3eOy for linux-arm-kernel@lists.infradead.org; Tue, 18 Nov 2025 19:06:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5B5DD43C9E; Tue, 18 Nov 2025 19:06:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6BB3C19421; Tue, 18 Nov 2025 19:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763492804; bh=7Uej8vFQyBecna9Eft7O2XmvApuSK/EcttFDPNfpMfs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PtPxeFpsTCUMy3B0/s9eZJtRfBN3Woqf70pKAph9EK0jd7Puhx2BUzOL+w4mV9IJb p/zsH5NWOhE3LPrQ1BkdpfvVuRG2BQDcR2aseYYXSAtheJnJa2Xcs7eyrwOWfqDzfF Tz/pCtMOkFC8LkHZMM8WFzaoBq7iEYvu5tbyb7VeEEH5gcgiBibU250YiQwgZXvpn6 NnG5Ht4yrgzDOFHp9hjw9qZ+RYcrFflJfIVnK5QHkz2CUeWSMKr5cr3QKTes64/8Qm Y4TQte2J0EUMApdinQOenZwP0oE1IWuYVoTLYrPsZSn1Qpf9jfMBaq7GMscAivG8Ej YVkWR8TGwxseA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vLR2G-00000006Im4-42i7; Tue, 18 Nov 2025 19:06:41 +0000 Date: Tue, 18 Nov 2025 19:06:40 +0000 Message-ID: <86ms4jrwhr.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: Oliver Upton , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Joey Gouly , Suzuki K Poulose , Zenghui Yu , Christoffer Dall , Mark Brown Subject: Re: [PATCH v3 0/5] KVM: arm64: Add LR overflow infrastructure (the dregs, the bad and the ugly) In-Reply-To: References: <20251117091527.1119213-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, christoffer.dall@arm.com, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251118_110647_085256_0966E753 X-CRM114-Status: GOOD ( 41.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fuad, On Tue, 18 Nov 2025 13:59:14 +0000, Fuad Tabba wrote: > > On Tue, 18 Nov 2025 at 07:20, Oliver Upton wrote: > > > > On Mon, Nov 17, 2025 at 09:15:22AM +0000, Marc Zyngier wrote: > > > This is a follow-up to the original series [1] (and fixes [2][3]) > > > with a bunch of bug-fixes and improvements. At least one patch has > > > already been posted, but I thought I might repost it as part of a > > > series, since I accumulated more stuff: > > > > > > - The first patch addresses Mark's observation that the no-vgic-v3 > > > test has been broken once more. At some point, we'll have to retire > > > that functionality, because even if we keep fixing the SR handling, > > > nobody tests the actual interrupt state exposure to userspace, which > > > I'm pretty sure has badly been broken for at least 5 years. > > > > > > - The second one addresses a report from Fuad that on QEMU, > > > ICH_HCR_EL2.TDIR traps ICC_DIR_EL1 on top of ICV_DIR_EL1, leading to > > > the host exploding on deactivating an interrupt. This behaviour is > > > allowed by the spec, so make sure we clear all trap bits > > > > > > - Running vgic_irq in an L1 guest (the test being an L2) results in a > > > MI storm on the host, as the state synchronisation is done at the > > > wrong place, much like it was on the non-NV path before it was > > > reworked. Apply the same methods to the NV code, and enjoy much > > > better MI emulation, now tested all the way into an L3. > > > > > > - Nuke a small leftover from previous rework. > > > > > > - Force a read-back of ICH_MISR_EL2 when disabling the vgic, so that > > > the trap prevents too many spurious MIs in an L1 guest, as the write > > > to ICH_HCR_EL2 does exactly nothing on its own when running under > > > FEAT_NV2. > > > > > > Oliver: this is starting to be a large series of fixes on top of the > > > existing series, plus the two patches you have already added. I'd be > > > happy to respin a full v4 with the fixes squashed into their original > > > patches. On the other hand, if you want to see the history in its full > > > glory, that also works for me. > > > > I'll pick up these patches in a moment but at this point I'd prefer a > > clean history. Plan is to send out the 6.19 pull sometime next week so > > any time before then would be great for v4. > > I'm happy to take that for another spin Marc before you send it, if > it's different from the ToT I tested. In that case, just send me a > pointer to the branch. I've just pushed out a full branch at [1]. Please make sure to merge kvmarm-fixes-6.18-3 in, as it fixes a couple of nasties (small conflict expected, but the resolution should be obvious). For my own testing, I added -rc6 on top. Note that I didn't take your Tested-by: tags, as you are about to retest the whole thing anyway. If all goes well (fingers crossed), Oliver will be able to apply any further tag once I post these patches. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/vgic-lr-overflow -- Without deviation from the norm, progress is not possible.