linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Sebastian Ott <sebott@redhat.com>
Cc: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
	kvmarm@lists.linux.dev, oliver.upton@linux.dev,
	catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
	cohuck@redhat.com, eric.auger@redhat.com, yuzenghui@huawei.com,
	wangzhou1@hisilicon.com, jiangkunkun@huawei.com,
	jonathan.cameron@huawei.com, anthony.jebson@huawei.com,
	linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
Subject: Re: [PATCH v7 4/5] smccc/kvm_guest: Enable errata based on implementation CPUs
Date: Fri, 14 Feb 2025 16:43:20 +0000	[thread overview]
Message-ID: <86mseoscif.wl-maz@kernel.org> (raw)
In-Reply-To: <10831a79-a21f-dc40-a374-81b300d26dac@redhat.com>

On Fri, 14 Feb 2025 16:12:02 +0000,
Sebastian Ott <sebott@redhat.com> wrote:
> 
> On Fri, 14 Feb 2025, Shameer Kolothum wrote:
> > +++ b/arch/arm64/kernel/cpu_errata.c
> > @@ -14,6 +14,9 @@
> > #include <asm/kvm_asm.h>
> > #include <asm/smp_plat.h>
> > 
> > +u32 target_impl_cpu_num;
> > +struct target_impl_cpu *target_impl_cpus;
> 
> These should be exported (for configs using
> CONFIG_CORESIGHT_SOURCE_ETM4X=m)

It might be better to make is_midr_in_range() out of line, and export
that. This could allow making the data static (by implementing a
couple of additional accessors).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.


  reply	other threads:[~2025-02-14 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 15:13 [PATCH v7 0/5] KVM: arm64: Errata management for VM Live migration Shameer Kolothum
2025-02-14 15:13 ` [PATCH v7 1/5] arm64: Modify _midr_range() functions to read MIDR/REVIDR internally Shameer Kolothum
2025-02-14 16:02   ` Sebastian Ott
2025-02-14 15:13 ` [PATCH v7 2/5] KVM: arm64: Introduce hypercall support for retrieving target implementations Shameer Kolothum
2025-02-14 15:13 ` [PATCH v7 3/5] KVM: arm64: Introduce KVM_REG_ARM_VENDOR_HYP_BMAP_2 Shameer Kolothum
2025-02-14 15:13 ` [PATCH v7 4/5] smccc/kvm_guest: Enable errata based on implementation CPUs Shameer Kolothum
2025-02-14 16:12   ` Sebastian Ott
2025-02-14 16:43     ` Marc Zyngier [this message]
2025-02-18  7:40       ` Shameerali Kolothum Thodi
2025-02-14 15:13 ` [PATCH v7 5/5] KVM: selftests: Add test for KVM_REG_ARM_VENDOR_HYP_BMAP_2 Shameer Kolothum
2025-02-14 17:34 ` [PATCH v7 0/5] KVM: arm64: Errata management for VM Live migration Sebastian Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mseoscif.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=anthony.jebson@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=cohuck@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jiangkunkun@huawei.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=oliver.upton@linux.dev \
    --cc=sebott@redhat.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).