From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74704C4332D for ; Sat, 21 Mar 2020 15:21:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4827520786 for ; Sat, 21 Mar 2020 15:21:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iaGTpUgd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sY+GDcxX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4827520786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DmbPNDPylR4iSkN/Ntt9uHsiIk60sR4d7/VzsWrLrBY=; b=iaGTpUgdBgyDVA rjyEnDAFO41cSxxjflwPdbFmQ8FoCuEEnp2UAZ7gmuoe1Z8TpCKGglMJWoVIEIpbk1vl6UWTEtjSX 9KlzGdJNsoENwfstaPqe4Wo8C76/P1MUQ1Blcmi6+xb0aJVsSJ7A/2NblKSlnKDmKnC2NxRM0YBu9 /vtDl91IpAr101p9yR/gX3bOHz3w43mB325Si+MtOWJsJsC8+DupeTDMI5ha7siJfwTx71EkafcNq Jnse0xVPFxAuqE9vgCsv6GU2AYXNftw292T5PKmt/wiC/uvlAE6YGFS9pxdLE2xcKCvcYddbZy7VD Ok/0y5buc0gffEScV9VA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFfw0-0004Wb-2R; Sat, 21 Mar 2020 15:21:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFfvw-0004WA-SP for linux-arm-kernel@lists.infradead.org; Sat, 21 Mar 2020 15:21:10 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EFDB20780; Sat, 21 Mar 2020 15:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584804068; bh=JVuxAv7PcFwI3VFWuqZ+qL64OlXsn6M06RjI7bB1CNQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sY+GDcxXQXt+MlE7vd2I0azOCUDnBZnE1+dy3Rw2fWty+8kWl79XPihhWwlaliWUS 84UyUpBPNLhmcDXYHLiRhKF40AW4eZ4f1KZahUw2vpx3JXChvDeCioMI7aoyybjAGD 2cy4INOaGTvlQCimdphmN4LF7w/KoJqXogXXdgj0= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=big-swifty.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFfvu-00EWKi-R7; Sat, 21 Mar 2020 15:21:06 +0000 Date: Sat, 21 Mar 2020 15:21:05 +0000 Message-ID: <86mu89zqce.wl-maz@kernel.org> From: Marc Zyngier To: Anson Huang Subject: Re: [PATCH] irqchip: irq-imx-gpcv2: Remove unnecessary blank lines In-Reply-To: <1584421001-2647-1-git-send-email-Anson.Huang@nxp.com> References: <1584421001-2647-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: Anson.Huang@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux-imx@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200321_082108_945080_E08EC1AA X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jason@lakedaemon.net, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, tglx@linutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Mar 2020 04:56:41 +0000, Anson Huang wrote: > > Remove unnecessary blank lines for cleanup. > > Signed-off-by: Anson Huang > --- > drivers/irqchip/irq-imx-gpcv2.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c > index 4f74c15..4f11b9b 100644 > --- a/drivers/irqchip/irq-imx-gpcv2.c > +++ b/drivers/irqchip/irq-imx-gpcv2.c > @@ -17,7 +17,6 @@ > #define GPC_IMR1_CORE2 0x1c0 > #define GPC_IMR1_CORE3 0x1d0 > > - > struct gpcv2_irqchip_data { > struct raw_spinlock rlock; > void __iomem *gpc_base; > @@ -287,6 +286,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node, > of_node_clear_flag(node, OF_POPULATED); > return 0; > } > - > IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init); > IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init); I honestly don't think this deserves a patch. Next time you work on this driver, add the cleanups to it. But on its own, it's only churn. Thanks, M. -- Jazz is not dead, it just smells funny. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel