From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69820EE57C4 for ; Wed, 11 Sep 2024 15:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=prG2JbdUtE9OXYKs+T5/VaxS2MAVffH5mDiOtwVSta4=; b=ufYk3Bez7twIjMUtIcjEpnlpJn uZt8Gl0Y1nVwe2z8RXL+rpYQHc0yVgb7jLsuQBk6gavUqw4A4ibug2eIEnPhf5PCrKqUu2H/ciQVK qiAHX7fZiZnXTGVfT/F759PE/KmLqqXFd6j83lsP0n7zUWpgO2SzC3Pb8lWbTz7TvGNvW9HCd2iHF WGchR3e9GBAe3URW1fo/nqV/QElGfk9JSfodd2HS/6wHxEajuBW11OJehWiUxLrPoJ6Th4QFjGBFn 18pY/JbKamyrofzZZvSmNp0dMMwqav4/xAJo7dBVJwZExa/u9EYMPNkXcb9Vr9txF7a9bKS5SeIS9 dQrUK2wA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soPga-0000000AFkr-0JzY; Wed, 11 Sep 2024 15:55:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soPQg-0000000AC4T-1vaj for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 15:38:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8CCE95C0592; Wed, 11 Sep 2024 15:38:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7413C4CEC7; Wed, 11 Sep 2024 15:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726069127; bh=QXNbUMRnp7GSpzgS2NMBHKjIaE+3Iot+Pwen86lwgm0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q2kRUeGqilM3z+qHYizbvhdFYxTz61KWW2q9694IOZOkj9LQhGIP5w0VgQI8WISU/ Q95oYFiblD2zkHFGtiwuY6hl+ghy+VgQkeGkXr8sF0it1oM6itF3/qdtlzuAWz/EUu ggHjXMwZtssNrcE/xTvAc6/zBV6LqpnLKGKNTHpjzOBD5x4Yc6E+Z2oYNmGdV2vsew ABovSiAJs0/c0co1y0sj1wJooFZpMz/t8mJDdEMGEPCN9TfBMW8WQV6o69RJBkinIy ta7yjGqMJABR3NdpucKri+WAjHgzrykeTVn5CaQyZ/DYSNe6FzL4vcUcRnRvKUOKyB 4kClu4N4nUvuA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1soPQb-00CALu-Q9; Wed, 11 Sep 2024 16:38:45 +0100 Date: Wed, 11 Sep 2024 16:38:45 +0100 Message-ID: <86o74u6vzu.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Alexandru Elisei , Mark Brown Subject: Re: [PATCH v3 18/24] KVM: arm64: Split S1 permission evaluation into direct and hierarchical parts In-Reply-To: <20240911141513.GA1080224@e124191.cambridge.arm.com> References: <20240911135151.401193-1-maz@kernel.org> <20240911135151.401193-19-maz@kernel.org> <20240911141513.GA1080224@e124191.cambridge.arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, alexandru.elisei@arm.com, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_083850_572668_E6191BA7 X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Sep 2024 15:15:13 +0100, Joey Gouly wrote: > > On Wed, Sep 11, 2024 at 02:51:45PM +0100, Marc Zyngier wrote: [...] > > +static void compute_s1_hierarchical_permissions(struct kvm_vcpu *vcpu, > > + struct s1_walk_info *wi, > > + struct s1_walk_result *wr, > > + struct s1_perms *s1p) > > +{ > > How about: > > if (wi->hpd) > return; I was hoping not to add anything like this, because all the table bits are 0 (we simply don't collect them), and thus don't have any effect. Or did you spot any edge case where that would result in in a different set of permissions? Thanks, M. -- Without deviation from the norm, progress is not possible.