From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D2CEC55172 for ; Tue, 4 Aug 2026 08:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i2Sc4KevYo2e/DN+nfNGhFdZJpINbxMeR2mT8GkX1MQ=; b=yEnx7f435SDkQFTIysldhtQGSQ Ww44wZUQwr/NdLBfrbxpr4CSHXDpFxEa8dmXZNxcXtQITut3Y+/DVgKV3PgNIkbSudJZ0pq7WKMFi ot8K8Du1OQ9zok2ywBGuJwHMUi3DWvx7TUilE+1QbtPRbtOs0jSbz9a4uwg5m8yfUalHrB4jL2vPc +U4pCfvF2At31aAORGOH80j3kee6lPrctb1T/zLH6RI7n+Tbe0wDYEI5pM02RTP2PsX2Uln4ctpse 3sOeBiPIB6EpJTTNBzA58KaUmX+keV3UZkRIbZeCxf/ilUsRIaWJuHQxs/jurG/+TgHBhfQi0KrxY rwcXXWxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrAoM-00000001NEe-00f2; Tue, 04 Aug 2026 08:47:46 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrAoK-00000001NEW-1yvg for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2026 08:47:44 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8806F600AA; Tue, 4 Aug 2026 08:47:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D6091F000E9; Tue, 4 Aug 2026 08:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785833263; bh=i2Sc4KevYo2e/DN+nfNGhFdZJpINbxMeR2mT8GkX1MQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bJv1JUNHsFwUtBva0IghvNhXPsAR3nJfWFEdmcVLlK/Cs9UCk2vEBnwgKqz1HXxQO llCf8ugFfEj2PM/R+tbZkR/nFfiahJCMWDqIzJTjWFD/ty/5Ok9uKKc9E5VzPVpY08 M9ePzluTWGhTrHQTOg6wPedTyindy8x2RvLBaJoyP9NNHCk8dQ2nakdN7td+5Oggh3 pFUzX5gD+fLuIQtURqwU97fyfX2asn7cNRyKlfodn44Dt2YoIsNiwji2Fh6jeRowX1 r+y/WFe8JFMYlPr84Se6OaUr+1yz6ro2b6OVXYFz54sSzf/g1cqrH33scxxoaNzepT 0WMdYIKaUtCEA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wrAoG-0000000C7YS-3lEp; Tue, 04 Aug 2026 08:47:40 +0000 Date: Tue, 04 Aug 2026 09:47:40 +0100 Message-ID: <86pkzyb7bn.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: oupton@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, alexandru.elisei@arm.com, vdonnefort@google.com, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, qperret@google.com, ardb@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/11] KVM: arm64: nVHE: Check hypercall handlers against the declared ABI In-Reply-To: References: <20260803124220.332248-1-fuad.tabba@linux.dev> <20260803124220.332248-11-fuad.tabba@linux.dev> <86qzkfaxp9.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, oupton@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, alexandru.elisei@arm.com, vdonnefort@google.com, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, qperret@google.com, ardb@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 03 Aug 2026 19:34:52 +0100, Fuad Tabba wrote: > > On Mon, 3 Aug 2026 at 19:03, Marc Zyngier wrote: > ... > > > > I've also dropped this with the following hacks. The set_cpu_reg() > > stuff isn't brilliant, and requires a single word type. But I find the > > overall scheme less invasive. > > > > WDYT? > > Works, and hyp-main.nvhe.o comes out byte identical. I did look for a > way to dispatch on void without the type table, but _Generic doesn't > take an incomplete type and __builtin_choose_expr type-checks both > arms on gcc and clang, so I don't think there's a better option. > > One nit: the declaration in kvm_hcall.h still says "unsigned long" > while the definition now says "ulong". Could we make both ulong? Yeah, that's an oversight. I don't like the ulong stuff at all, but I don't see how to do this without it. > > I'm happy to respin with both of these, or would you like to fold them in? Oliver is in charge of 7.3, so I'll let him reply on this. Thanks, M. -- Without deviation from the norm, progress is not possible.