From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F668D29FEF for ; Wed, 14 Jan 2026 12:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=USNHuLFwPRQ9K5vdWe/euxnsqLlwiBOFDxiRkRA+v0s=; b=XW4Jwq9KRLPhrGsLCbt/bjL9qk r255QnnQHkji5Wx9QsBulvZdgq1zIfdIXREmYGxssGsbK97uum6sbuUEFlJtJeOV53+STAw0SoT2Y viQGxP4pDStSciyhQhrsHY/0+eSJRWrQMX0HTVIYh/M6zKjAVzhmWKSi+yDcud9NoOe/HkfxA+/Qb rz7hWaOZQsO0QrpXgHousp1d1SNM1Qbee87WbY1jqjit7UW+R8mFjZpBAmdbnMefr5AofveavC4nq eZBQDmOgLPZSBNkcv0fo4/Bc9jWBSvg/Wnoy4j9BLXbYa52BVEWsvNZw6fwDPLjXGK0JT/evxOdDx P//Mx69w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfze5-000000095dt-27u0; Wed, 14 Jan 2026 12:06:41 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfzdw-000000095c3-2eHA for linux-arm-kernel@lists.infradead.org; Wed, 14 Jan 2026 12:06:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A27EA402F9; Wed, 14 Jan 2026 12:06:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73D1CC16AAE; Wed, 14 Jan 2026 12:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768392391; bh=IXiea1JAWy8hq5EFO/KtmMlzvJWcD+fDKDcocQOcQFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DOF9TCfDTk6eih11jEFeuuENrvGypFtZ6oAZOvC8fddU3ObXKUkomJ3EBphmogvlI lbzyTJ7ODiErL3sk+WZIGKvpN2GSfjVVf1M6XAwYmgkJRj2Y3JJHe842j9dOpdk4b/ /gWuRf3m7/3JHU25MM8R5fcZZ9UAFMJBQt9FXhdCLfzdl0ThRIHAY6JIV3XXcltMBc PJYphZmZ8pN4WNZhQ+oi02UI5wgpEQafeU0sAQX/8lFVLn9koX2rE9KvyWi3K2GQwx h+ZKO4Ia7nkrG4WTFhaqLv5ZUW+/rtZ9G4c5bwnbQMjhWlFt2T+Mi3KZqmoY+yGYDY kZxSYGqWMsDBw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vfzds-00000002AbS-4B8R; Wed, 14 Jan 2026 12:06:29 +0000 Date: Wed, 14 Jan 2026 12:06:28 +0000 Message-ID: <86pl7cl7p7.wl-maz@kernel.org> From: Marc Zyngier To: Ben Horgan Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com, dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com, fenghuay@nvidia.com, gshan@redhat.com, james.morse@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peternewman@google.com, punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com, reinette.chatre@intel.com, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, kvmarm@lists.linux.dev Subject: Re: [PATCH v3 12/47] KVM: arm64: Force guest EL1 to use user-space's partid configuration In-Reply-To: <20260112165914.4086692-13-ben.horgan@arm.com> References: <20260112165914.4086692-1-ben.horgan@arm.com> <20260112165914.4086692-13-ben.horgan@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ben.horgan@arm.com, amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com, dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com, fenghuay@nvidia.com, gshan@redhat.com, james.morse@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peternewman@google.com, punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com, reinette.chatre@intel.com, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260114_040633_972706_C1B1D310 X-CRM114-Status: GOOD ( 25.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Jan 2026 16:58:39 +0000, Ben Horgan wrote: > > From: James Morse > > While we trap the guest's attempts to read/write the MPAM control > registers, the hardware continues to use them. Guest-EL0 uses KVM's > user-space's configuration, as the value is left in the register, and > guest-EL1 uses either the host kernel's configuration, or in the case of > VHE, the UNKNOWN reset value of MPAM1_EL1. > > We want to force the guest-EL1 to use KVM's user-space's MPAM > configuration. On nVHE rely on MPAM0_EL1 and MPAM1_EL1 always being > programmed the same and on VHE copy MPAM0_EL1 into the guest's > MPAM1_EL1. There is no need to restore as this is out of context once TGE > is set. > > Signed-off-by: James Morse > Signed-off-by: Ben Horgan > --- > Changes since rfc: > Drop the unneeded __mpam_guest_load() in nvhre and the MPAM1_EL1 save restore > Defer EL2 handling until next patch > > Changes since v2: > Use mask (Oliver) > --- > arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > index f28c6cf4fe1b..9fb8e6628611 100644 > --- a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > +++ b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > @@ -183,6 +183,18 @@ void sysreg_restore_guest_state_vhe(struct kvm_cpu_context *ctxt) > } > NOKPROBE_SYMBOL(sysreg_restore_guest_state_vhe); > > +/* > + * The _EL0 value was written by the host's context switch and belongs to the > + * VMM. Copy this into the guest's _EL1 register. > + */ > +static inline void __mpam_guest_load(void) > +{ > + u64 mask = MPAM0_EL1_PARTID_D | MPAM0_EL1_PARTID_I | MPAM0_EL1_PMG_D | MPAM0_EL1_PMG_I; > + > + if (system_supports_mpam()) > + write_sysreg_el1(read_sysreg_s(SYS_MPAM0_EL1) & mask, SYS_MPAM1); > +} > + > /** > * __vcpu_load_switch_sysregs - Load guest system registers to the physical CPU > * > @@ -222,6 +234,7 @@ void __vcpu_load_switch_sysregs(struct kvm_vcpu *vcpu) > */ > __sysreg32_restore_state(vcpu); > __sysreg_restore_user_state(guest_ctxt); > + __mpam_guest_load(); What's the rationale for doing this independently of rest of the MPAM stuff in __activate_traps_mpam()? M. -- Without deviation from the norm, progress is not possible.