From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH] KVM: arm64: Fix kvm_vcpu_{set,is}_be() to deal with EL2 state
Date: Wed, 17 Sep 2025 09:21:34 +0100 [thread overview]
Message-ID: <86plbp1oc1.wl-maz@kernel.org> (raw)
In-Reply-To: <aMpFRYarTozl7Q38@linux.dev>
On Wed, 17 Sep 2025 06:21:09 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> On Tue, Sep 16, 2025 at 05:11:03PM +0100, Marc Zyngier wrote:
> > Nobody really cares about BE, but KVM currently only deals with
> > SCTLR_EL1 when evaluating or setting the endianness in PSCI,
> > meaning that we evaluate whatever the L2 state has been at some point.
> >
> > Teach these primitives about SCTLR_EL2, and forget about BE...
> >
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> You know, I was about to say "don't we need to sanitise this?" although
> that seems to already be in place. Nice.
Only for SCTLR_EL1.
SCTLR_EL2, annoyingly enough, isn't, owing to plenty of bits depending
on E2H. It's on my long list of things to address, but I'd like a
common mechanism that'd deal with horrors such as CNTHCTL_EL2...
> Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-09-17 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 16:11 [PATCH] KVM: arm64: Fix kvm_vcpu_{set,is}_be() to deal with EL2 state Marc Zyngier
2025-09-17 5:21 ` Oliver Upton
2025-09-17 8:21 ` Marc Zyngier [this message]
2025-09-17 16:42 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plbp1oc1.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).