From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35FDAC4828F for ; Wed, 7 Feb 2024 10:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zHxCSBuEMyLCpavICvG3OFa2MXwlx4+x2z7cxvtu3a8=; b=tGxEG/xg88+0O5 CJPy5G7D7VZ2A7uGwrvZVVuUPsFVnd/EtgwkiMhvFNYtpXPPu2H5ueem5SuPPWVpWNRFMISpWg5gA ExJq6WpvxI34bNfCQFhUKks/wTPDU6ym1kEt7EaUFWoBYKwYvoqaVZ6Mq94HVMMVTZzRjRkYqeapY TGk0Yad1p/4JkorCmB/F/nlomLfAquoW2AvaytkCQOj6swqRK2c+HARP52iJagFFvwrAXjiIEWZwy 6EIE2SbF59nmPxrfeS+CJptrbrdQ7RA37SmvJp0vUqYqhUCw7PwgYnzZYuXA4jo77uB0GecaTa4dH LmfYAJ7PM3f4icL3a+7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXfcS-0000000AQ0I-25P3; Wed, 07 Feb 2024 10:57:32 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXfcP-0000000APzo-45Jq for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 10:57:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5EE9E617F1; Wed, 7 Feb 2024 10:57:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 021DFC433C7; Wed, 7 Feb 2024 10:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707303449; bh=aLLvXJglkNXytBnsPhnrcIuM6ogLdIutcYOhErhjbfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HAM20hA3zkFi6eFifC7tRI0AvHl6rTF++/kCXk3Cx0vQtB8p98DAWkjhAEogqNujF 5OMbHD4b+R+y0IfCq32Xiq2jZIRHBmHE3ywzUF15srfMBDpqlvZg5BWbjI86zaRJfs 5oTaeM/eqC3lNPxYXSZYJjECtS1kUhcWcg00heUJmH/tXvmmDFPWVZXzsMIlVn5lTf p5tgLSsbwSJb+CLy59+LSkpKzW/VcMxZZXAyv6+T5ekzALxWWutpDRn5vFjZtaRcuE YgQhetzuGxTojwZkZ6m2sSN6cRWyTAeBVeV19blB/jpm+zg7CFH93WbzgLjiCj15iR f1XAnjqEi6rZQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rXfcM-001627-Kk; Wed, 07 Feb 2024 10:57:26 +0000 Date: Wed, 07 Feb 2024 10:57:26 +0000 Message-ID: <86plx85yp5.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Joey Gouly , Mark Brown Subject: Re: [PATCH v3 04/26] KVM: arm64: nv: Add sanitising to EL2 configuration registers In-Reply-To: References: <20240205103431.1104133-1-maz@kernel.org> <20240205103431.1104133-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_025730_076995_007B5CFE X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 07 Feb 2024 10:40:08 +0000, Oliver Upton wrote: > > On Mon, Feb 05, 2024 at 10:34:09AM +0000, Marc Zyngier wrote: > > + if (!(__vcpu_has_feature(&kvm->arch, KVM_ARM_VCPU_PTRAUTH_ADDRESS) && > > + __vcpu_has_feature(&kvm->arch, KVM_ARM_VCPU_PTRAUTH_ADDRESS))) > > + res0 |= (HCR_API | HCR_APK); > > I think what you probably meant here is _ADDRESS and _GENERIC, right? Of > course, this has no actual effect on the code, since we don't allow one > without the other. Gah. Embarrassing. But yes, harmless as we set both bits all the time. > Maybe we can just change KVM's representation to a single flag to avoid > this pointless exercise. Yeah, it's been on my list of things to cleanup for a while. I'll look into it for a separate patch. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel