From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E04DC4332F for ; Mon, 30 Oct 2023 07:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HEv1uU9UGu0rjp+NE5cAUQxciG1F1ZnIqW9m2S9IUhk=; b=CxQufLMa9fxcRc WlQ7jRiO6ObRf0+mO5rv8pvap33bFBVpc6IYLu9PALCL46vgbzz/gEZs2wXGGFdjcXyjJN8Ng61dy wMLBAjq+PiiGGPQWo+TFx8riOFqAsHGdzXPfRLPqqje8oKclUamntWogTNyr933mQ91BCMECMFF1a p3oOoU5771lm1DmxxIIZrgL1G2iyHFe3dWTl2Lav/+QmnqXz45CxsVkBddUW8zNwj7OCcxUZOSAF3 FfMv9cUikXhQLP/Tp9nCtUoYpCe/70IZk68kbV/IRpxzxxiYh+w/yHT19xs+nKE2VYWN3v0fsPxlU KdP5fj/eeD+Adf4ejH4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxN0o-002mtb-1A; Mon, 30 Oct 2023 07:48:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxN0d-002msL-2A for linux-arm-kernel@lists.infradead.org; Mon, 30 Oct 2023 07:48:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 474CD60AD8; Mon, 30 Oct 2023 07:48:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0888BC433C7; Mon, 30 Oct 2023 07:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698652104; bh=9ZYjAbeiDueiB+lgVz4SsBHkwUtc4/ScPO1cuZQ4Q5s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i4WvaKjEW9TceEGr0pDhHfS5IVIZABXOUizSyy6xZTLzkfA6NUdGgK1kuZkAsCjUX DxnWms00OOOjD6YIM0BpZKdocF2XgHFKS3nRnKC1TR+wKObtdgS0C3HHq5SWx+Gs2V /JnrNUx62WKhgOM4tRWsWLOR/1EqLIK4TDK//PbvI7C5Nu//cAMeyO7OkFIHhZTjo5 HxGOd7YPAYwfZDIJjfY4sPK5CyKZb+3X8shuvFgv/Efw01mS2nz3jTSE66U+oh1Wr2 roQHmcODiBUx9vEe7mChKjhXjWPssfzsDU+bI1ZJafo7iP0wpghoBI+DBuitkaQE/V 2f2F1W359YSJA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qxN0X-008qI7-HF; Mon, 30 Oct 2023 07:48:21 +0000 Date: Mon, 30 Oct 2023 07:48:12 +0000 Message-ID: <86pm0w1rgj.wl-maz@kernel.org> From: Marc Zyngier To: Fang Xiang Cc: , , Subject: Re: [PATCH v3] irqchip/gic-v3-its: Flush ITS tables before writing GITS_BASER registers in non-coherent GIC designs. In-Reply-To: <20231030070020.3689-1-fangxiang3@xiaomi.com> References: <20231030070020.3689-1-fangxiang3@xiaomi.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fangxiang3@xiaomi.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231030_004827_770528_93338404 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 30 Oct 2023 07:00:20 +0000, Fang Xiang wrote: > > In non-coherent GIC design, ITS tables should be clean and flushed > to the PoV of the ITS before writing GITS_BASER registers, otherwise > the ITS would read dirty tables and lead to UNPREDICTABLE behaviors. > > The ITS always got clean tables in initialization with this fix, by > observing the signals from GIC. > > Furthermore, hoist the quirked non-shareable attributes earlier to > save effort in tables setup. > > Signed-off-by: Marc Zyngier Please read the documentation[1]. You cannot use my own SoB yourself. *I* put it on patches *I* author, but you don't get to do that unless you put me as the author (which isn't the case here). The original suggestion from Thomas was 'Originally-by:', and 'Suggested-by:' would work as well. > Signed-off-by: Fang Xiang > Tested-by: Fang Xiang > > Link to v2: > https://lore.kernel.org/all/20231027031007.2088-1-fangxiang3@xiaomi.com/ > > Link to v1: > https://lore.kernel.org/all/20231026020116.4238-1-fangxiang3@xiaomi.com/ > > v2 -> v3: > - Add 'Signed-off-by' trailer for original author Marc > - Expand commit message with testing result > > v1 -> v2: > - Flush ITS tables before writing GITS_BASER registers > - Hoist the quirked non-shareable attributes earlier All this needs to go as a note *under* the '---' line. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n396 -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel