From: D Scott Phillips <scott@os.amperecomputing.com>
To: James Morse <james.morse@arm.com>, linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Darren Hart <darren@os.amperecomputing.com>
Subject: Re: [PATCH v6] arm64: sdei: abort running SDEI handlers during crash
Date: Thu, 06 Jul 2023 15:00:22 -0700 [thread overview]
Message-ID: <86pm54wvih.fsf@scott-ph-mail.amperecomputing.com> (raw)
In-Reply-To: <20230627002939.2758-1-scott@os.amperecomputing.com>
D Scott Phillips <scott@os.amperecomputing.com> writes:
> Interrupts are blocked in SDEI context, per the SDEI spec: "The client
> interrupts cannot preempt the event handler." If we crashed in the SDEI
> handler-running context (as with ACPI's AGDI) then we need to clean up the
> SDEI state before proceeding to the crash kernel so that the crash kernel
> can have working interrupts.
>
> Track the active SDEI handler per-cpu so that we can COMPLETE_AND_RESUME
> the handler, discarding the interrupted context.
>
> Fixes: f5df26961853 ("arm64: kernel: Add arch-specific SDEI entry code and CPU masking")
> Signed-off-by: D Scott Phillips <scott@os.amperecomputing.com>
> Cc: stable@vger.kernel.org
> ---
> Changes since v5:
> - move sdei_handler_abort() to drivers/firmware/arm_sdei.c so that header
> changes don't break x86.
> v5 Link: https://lore.kernel.org/linux-arm-kernel/20230626074748.2785-1-scott@os.amperecomputing.com/
Hi James, sorry for the thrash on this, mea culpa. Would you mind taking
another look at the patch with the code moved around to fix my build
breakage?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-06 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 0:29 [PATCH v6] arm64: sdei: abort running SDEI handlers during crash D Scott Phillips
2023-07-06 22:00 ` D Scott Phillips [this message]
2023-07-20 9:43 ` Mihai Carabas
2023-08-02 14:24 ` James Morse
2023-08-04 18:10 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pm54wvih.fsf@scott-ph-mail.amperecomputing.com \
--to=scott@os.amperecomputing.com \
--cc=catalin.marinas@arm.com \
--cc=darren@os.amperecomputing.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).