From: Marc Zyngier <maz@kernel.org>
To: Tyler Hicks <code@tyhicks.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vijay Balakrishna <vijayb@linux.microsoft.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Fix event stream param in Kconfig
Date: Tue, 25 Oct 2022 11:24:55 +0100 [thread overview]
Message-ID: <86pmegdwug.wl-maz@kernel.org> (raw)
In-Reply-To: <20221024195118.871907-1-code@tyhicks.com>
Hi Tyler,
On Mon, 24 Oct 2022 20:51:18 +0100,
Tyler Hicks <code@tyhicks.com> wrote:
>
> From: "Tyler Hicks (Microsoft)" <code@tyhicks.com>
>
> Fix the event stream timer command line parameter name that's documented
> in the Kconfig description for CONFIG_ARM_ARCH_TIMER_EVTSTREAM. It
> didn't match the command line parameter name that's actually honored in
> the source code.
>
> Reported-by: Vijay Balakrishna <vijayb@linux.microsoft.com>
> Fixes: 46fd5c6b3059 ("clocksource/drivers/arm_arch_timer: Control the evtstrm via the cmdline")
> Cc: stable@vger.kernel.org
No, this really doesn't deserve a Cc: stable. This bit may be wrong,
but we have the correct information in the kernel-parameters.txt file,
which is authoritative AFAIC.
> Signed-off-by: Tyler Hicks (Microsoft) <code@tyhicks.com>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 4469e7f555e9..dcc274460973 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -315,7 +315,7 @@ config ARM_ARCH_TIMER_EVTSTREAM
> executing the wfe instruction at a frequency represented as a
> power-of-2 divisor of the clock rate. The behaviour can also be
> overridden on the command line using the
> - clocksource.arm_arch_timer.evtstream parameter.
> + clocksource.arm_arch_timer.evtstrm parameter.
> The main use of the event stream is wfe-based timeouts of userspace
> locking implementations. It might also be useful for imposing timeout
> on wfe to safeguard against any programming errors in case an expected
With this tag dropped,
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-25 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 19:51 [PATCH] clocksource/drivers/arm_arch_timer: Fix event stream param in Kconfig Tyler Hicks
2022-10-25 10:24 ` Marc Zyngier [this message]
2022-10-25 14:18 ` Tyler Hicks (Microsoft)
2022-10-25 15:07 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pmegdwug.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=code@tyhicks.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
--cc=vijayb@linux.microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).