From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC020F54ACF for ; Tue, 24 Mar 2026 15:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JWSCsbtfXn5z0NeDFFazyKqyiRLeFF3V8kVRpX3pCu0=; b=Owrll2R+MhumuFPFsF75rWYui6 MjnN8mmyLXtHZ0rBrj+DaxZ3RsdEmu6otYCJC0yi1gffiGQIoRIgdcMwisFvXVRyBWQuI1MiZK+1f uMuY3F05zhPzQx0BOsGoYW6ydsl77fJfej5+DkJeyBaJvpnRHY4vJth42Lx1rscr4aXzHin3heyX/ pI2XDHYACY8RWp9ijsmoBgcZB7qiAssWYOMRcvnNOJ3gtTSa0AkaYZfiUo6HXipG1PNqRPOgdY4hn aQd/lYT3SP7QE/E17bQlNXWmD0BAewusLI4GF/8NNxJfIgF18a2am4M/kKPzi0gZ61ZvxJfaiAjhH 5VDtWvHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w53dA-00000001kvu-0zUO; Tue, 24 Mar 2026 15:25:20 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w53d7-00000001kvU-3U2F for linux-arm-kernel@lists.infradead.org; Tue, 24 Mar 2026 15:25:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3FB2A44087; Tue, 24 Mar 2026 15:25:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13271C2BC87; Tue, 24 Mar 2026 15:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774365917; bh=jApd22MwXP4kVmFARWDF3a02qCZWDjk74CVTyqe0SMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PjkSgE9h8/nMHqcq4TuCl0qDggunZNcdipIVCA748Np9dKVXJQu1GzYEduv2BlieJ eHw8dUVzaA4cp2ncZx9e7qWVBuOdrwfw0pdZJHE+t7Yt4j6BrCyauAe+hAGgGxVaxo 9Y93AdBc2/J7phQrsBrVq9niTPQ8nY8MYLsBMGFIlHWW0QeNFF2omfrbtf29+bGfVx SBluMlKhJaMp8Nty4gbpKSCvjNzPlnOoWkpj5ShmEGH8f4pJM7g/2QyLdHAexLhoQ8 bj/NmN8mEmUqYRUtBC6XG7oQITwjNzekMHbiD0/71Gxs6QT+9S5mtqjbiu92a/Ym6T DRUjraGelaEIQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w53d4-00000005Dxd-2yy7; Tue, 24 Mar 2026 15:25:14 +0000 Date: Tue, 24 Mar 2026 15:25:14 +0000 Message-ID: <86qzp945d1.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Sascha Bischoff , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , nd , "oliver.upton@linux.dev" , Joey Gouly , Suzuki Poulose , "yuzenghui@huawei.com" , "peter.maydell@linaro.org" , "lpieralisi@kernel.org" , Timothy Hayes , "jonathan.cameron@huawei.com" Subject: Re: [PATCH v7 12/41] KVM: arm64: gic-v5: Sanitize ID_AA64PFR2_EL1.GCIE In-Reply-To: References: <20260319154937.3619520-1-sascha.bischoff@arm.com> <20260319154937.3619520-13-sascha.bischoff@arm.com> <638a3453-91c9-4a76-8241-25d5c27ca518@sirena.org.uk> <86se9p472z.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, Sascha.Bischoff@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, nd@arm.com, oliver.upton@linux.dev, Joey.Gouly@arm.com, Suzuki.Poulose@arm.com, yuzenghui@huawei.com, peter.maydell@linaro.org, lpieralisi@kernel.org, Timothy.Hayes@arm.com, jonathan.cameron@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260324_082517_908309_360A462E X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 24 Mar 2026 14:53:58 +0000, Mark Brown wrote: > > [1 ] > On Tue, Mar 24, 2026 at 02:48:04PM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > We're also seeing an issue with this in the aarch32_id_regs test: > > ... > > > > which for some reason only manifests on TX2 of the platforms I've > > > seen. > > > Is your TX2 the only machine you have that is AArch64 only at all ELs? > > Yes, that should be the case. The hack below fixes it on my favourite Qualcomm box. M. diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c index fd872079f2a24..7212cb3766d3d 100644 --- a/arch/arm64/kvm/vgic/vgic-init.c +++ b/arch/arm64/kvm/vgic/vgic-init.c @@ -696,7 +696,8 @@ void kvm_vgic_finalize_idregs(struct kvm *kvm) break; case KVM_DEV_TYPE_ARM_VGIC_V3: aa64pfr0 |= SYS_FIELD_PREP_ENUM(ID_AA64PFR0_EL1, GIC, IMP); - pfr1 |= SYS_FIELD_PREP_ENUM(ID_PFR1_EL1, GIC, GICv3); + if (kvm_supports_32bit_el0()) + pfr1 |= SYS_FIELD_PREP_ENUM(ID_PFR1_EL1, GIC, GICv3); break; case KVM_DEV_TYPE_ARM_VGIC_V5: aa64pfr2 |= SYS_FIELD_PREP_ENUM(ID_AA64PFR2_EL1, GCIE, IMP); -- Without deviation from the norm, progress is not possible.