From: Marc Zyngier <maz@kernel.org>
To: Christian Bruel <christian.bruel@foss.st.com>
Cc: <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: st: Use 128kB size for aliased GIC400 register access
Date: Tue, 08 Apr 2025 17:46:09 +0100 [thread overview]
Message-ID: <86r022lhym.wl-maz@kernel.org> (raw)
In-Reply-To: <20250407084028.2072504-1-christian.bruel@foss.st.com>
On Mon, 07 Apr 2025 09:40:28 +0100,
Christian Bruel <christian.bruel@foss.st.com> wrote:
>
> Adjust the size of 8kB GIC regions to 128kB so that each 4kB is mapped
> to 64kB. The offset is then adjusted in the irq-gic driver.
nit: mapped *16 times* over a 64kB region.
>
> see commit 12e14066f4835 ("irqchip/GIC: Add workaround for aliased GIC400")
>
> Fixes: 5d30d03aaf785 ("arm64: dts: st: introduce stm32mp25 SoCs family")
> Signed-off-by: Christian Bruel <christian.bruel@foss.st.com>
> ---
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 379e290313dc..87110f91e489 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -119,9 +119,9 @@ intc: interrupt-controller@4ac00000 {
> #interrupt-cells = <3>;
> interrupt-controller;
> reg = <0x0 0x4ac10000 0x0 0x1000>,
> - <0x0 0x4ac20000 0x0 0x2000>,
> - <0x0 0x4ac40000 0x0 0x2000>,
> - <0x0 0x4ac60000 0x0 0x2000>;
> + <0x0 0x4ac20000 0x0 0x20000>,
> + <0x0 0x4ac40000 0x0 0x20000>,
> + <0x0 0x4ac60000 0x0 0x20000>;
> };
>
> psci {
Suggested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2025-04-08 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 8:40 [PATCH 2/2] arm64: dts: st: Use 128kB size for aliased GIC400 register access Christian Bruel
2025-04-08 16:46 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r022lhym.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=christian.bruel@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).