linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] arm64: dts: st: Use 128kB size for aliased GIC400 register access
@ 2025-04-07  8:40 Christian Bruel
  2025-04-08 16:46 ` Marc Zyngier
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Bruel @ 2025-04-07  8:40 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, mcoquelin.stm32, alexandre.torgue
  Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, maz,
	Christian Bruel

Adjust the size of 8kB GIC regions to 128kB so that each 4kB is mapped
to 64kB. The offset is then adjusted in the irq-gic driver.

see commit 12e14066f4835 ("irqchip/GIC: Add workaround for aliased GIC400")

Fixes: 5d30d03aaf785 ("arm64: dts: st: introduce stm32mp25 SoCs family")
Signed-off-by: Christian Bruel <christian.bruel@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp251.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
index 379e290313dc..87110f91e489 100644
--- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
@@ -119,9 +119,9 @@ intc: interrupt-controller@4ac00000 {
 		#interrupt-cells = <3>;
 		interrupt-controller;
 		reg = <0x0 0x4ac10000 0x0 0x1000>,
-		      <0x0 0x4ac20000 0x0 0x2000>,
-		      <0x0 0x4ac40000 0x0 0x2000>,
-		      <0x0 0x4ac60000 0x0 0x2000>;
+		      <0x0 0x4ac20000 0x0 0x20000>,
+		      <0x0 0x4ac40000 0x0 0x20000>,
+		      <0x0 0x4ac60000 0x0 0x20000>;
 	};
 
 	psci {
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] arm64: dts: st: Use 128kB size for aliased GIC400 register access
  2025-04-07  8:40 [PATCH 2/2] arm64: dts: st: Use 128kB size for aliased GIC400 register access Christian Bruel
@ 2025-04-08 16:46 ` Marc Zyngier
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2025-04-08 16:46 UTC (permalink / raw)
  To: Christian Bruel
  Cc: robh, krzk+dt, conor+dt, mcoquelin.stm32, alexandre.torgue,
	devicetree, linux-stm32, linux-arm-kernel, linux-kernel

On Mon, 07 Apr 2025 09:40:28 +0100,
Christian Bruel <christian.bruel@foss.st.com> wrote:
> 
> Adjust the size of 8kB GIC regions to 128kB so that each 4kB is mapped
> to 64kB. The offset is then adjusted in the irq-gic driver.

nit: mapped *16 times* over a 64kB region.

> 
> see commit 12e14066f4835 ("irqchip/GIC: Add workaround for aliased GIC400")
> 
> Fixes: 5d30d03aaf785 ("arm64: dts: st: introduce stm32mp25 SoCs family")
> Signed-off-by: Christian Bruel <christian.bruel@foss.st.com>
> ---
>  arch/arm64/boot/dts/st/stm32mp251.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 379e290313dc..87110f91e489 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -119,9 +119,9 @@ intc: interrupt-controller@4ac00000 {
>  		#interrupt-cells = <3>;
>  		interrupt-controller;
>  		reg = <0x0 0x4ac10000 0x0 0x1000>,
> -		      <0x0 0x4ac20000 0x0 0x2000>,
> -		      <0x0 0x4ac40000 0x0 0x2000>,
> -		      <0x0 0x4ac60000 0x0 0x2000>;
> +		      <0x0 0x4ac20000 0x0 0x20000>,
> +		      <0x0 0x4ac40000 0x0 0x20000>,
> +		      <0x0 0x4ac60000 0x0 0x20000>;
>  	};
>  
>  	psci {

Suggested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-08 16:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07  8:40 [PATCH 2/2] arm64: dts: st: Use 128kB size for aliased GIC400 register access Christian Bruel
2025-04-08 16:46 ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).