From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B742606A333 for ; Wed, 11 Nov 2026 09:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=iIr/seoF; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FiDTk9HN DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=htR73Z6NVxU0lkG220sIaALTFHPkl5m16dbexXoczJ0=; b=iIr/seoF4OjBp1SVF9LAV53655 INCXR84msOtJuVKSuq+GZnBW29UFA8642jRzk8KJ4MHxFiMwP/T2qizffDQWn21a4En2vRCi+5eT4 1sZhVpdkQNnHzTd5Wa6oTH0vbCofweIMYZ49DK6loabxJ6EvznsuUiiV3AF8Nv9uz0DMujG1JINzp SCo7KiN9wD/OcaMBxRULhHxlpS1W+Ozfe1d8ytIDsg8PPV8X41d2//G99nsmnmNy6pKVu7CmoEEiu wcKJpTsc3zs/HGxWb8AuqqqerqnHKbhGsfcGKAeFui9QrQcRqHvkv/8QtuWUuGDyZy2sSZeL5mCzf NSkzlJgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR4Kp-000000068KV-12yJ; Wed, 11 Nov 2026 09:09:39 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR4Ko-000000068KN-0DRX for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2026 09:09:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A27E0413C2; Wed, 11 Nov 2026 09:09:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 825D31F00A05; Wed, 11 Nov 2026 09:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794388177; bh=htR73Z6NVxU0lkG220sIaALTFHPkl5m16dbexXoczJ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=FiDTk9HNHaNkX2ypeG3Omgun2J6T0+Ry4iViwS3mepi1nuRCo7SACBz5SN99gYFNj HauQ3qwNyKf6GiL7+xIpDQvB42fI6P6B0ESdm8HUPTaQlvv7obkPOydwo7h+WnwJB9 fb65GIj4iVHHm/ZGShyjXfgPxehyGD/kE/c9d1a9fgnLyBHl0Yf7uMLdYLmy4RUMLD pwphhR639xg6/qsmD1Qd5QBhUACptY36zXITFA3P7Qd/RwT5RNcVagPWjR2qUCCAy+ JKJ+eJkC+V9pqMVQkI7YVdw6af11rZiiLpRUUa86Usw0dJ8JDSryncBTLF1MrNvumo txEKZLdHgXiMQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xR4Kl-0000000ECif-06Cb; Wed, 11 Nov 2026 09:09:35 +0000 Date: Wed, 11 Nov 2026 09:09:34 +0000 Message-ID: <86se1720q9.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: Thomas Gleixner , Radu Rendec , Steven Price , Suzuki K Poulose , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] irqchip/gic-v3-its: Fix the ITT pool's alignment, zeroing and growth In-Reply-To: <20261106092625.3977163-1-fuad.tabba@linux.dev> References: <20261106092625.3977163-1-fuad.tabba@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Archived-By: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, tglx@kernel.org, radu@rendec.net, steven.price@arm.com, suzuki.poulose@arm.com, will@kernel.org, tabba@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, 06 Nov 2026 09:26:22 +0000, Fuad Tabba wrote: > > Hi folks, > > Three fixes to the ITT pool that took over sub-page ITTs from > kzalloc_node(). It doesn't align them to 256 bytes, though MAPD now > relies on it to. It doesn't zero the ITTs it reuses either, and it > leaks pages when it fails to grow. > > The first gives the pool a 256-byte granule. With its 1-byte granule, > ITTs stay aligned only while every size is a multiple of 256, which > holds for power-of-two ITE sizes but not for QEMU's 12-byte ones. On > QEMU, two devices with 32 MSI-X vectors each are enough to put the > second device's ITT at an address MAPD truncates into the first's. > > The second zeroes an ITT reused from the pool, as MAPD requires. The > third frees the page when gen_pool_add() fails. How does it relate to the series you posted right after (20261106120221.347309-1-fuad.tabba@linux.dev)? They both deal with all sort of zeroing and allocation requirements. So why isn't this one single consistent series? The scatter-gun approach you keep using is really becoming counter-productive. I really appreciate the effort you are putting in fixing the code, but please realise that humans are reviewing this, not an AI. So please make it at least easy to track and keep related things together. Thanks, M. -- Without deviation from the norm, progress is not possible.