public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip/gic: Use GIC_SPI symbolic constant
Date: Sun, 16 Jul 2017 21:13:47 +0100	[thread overview]
Message-ID: <86shhwywas.fsf@arm.com> (raw)
In-Reply-To: <e25e0ac5-abe2-6024-f669-c5352183114e@free.fr> (Mason's message of "Sun, 16 Jul 2017 19:40:06 +0200")

On Sun, Jul 16 2017 at  7:40:06 pm BST, Mason <slash.tmp@free.fr> wrote:
> Use GIC_SPI explicitly instead of an implicit 0.

What bug is this fixing? What benefit does this bring?

>
> Signed-off-by: Mason <slash.tmp@free.fr>
> ---
> FWIW, 'make C=2' flagged a few lines:
>
> $ make C=2 drivers/irqchip/irq-gic.o
>   CHECK   drivers/irqchip/irq-gic.c
> drivers/irqchip/irq-gic.c:1079:44: warning: incorrect type in assignment (different address spaces)
> drivers/irqchip/irq-gic.c:1079:44:    expected void [noderef] <asn:3>*[noderef] <asn:2>*percpu_base
> drivers/irqchip/irq-gic.c:1079:44:    got void [noderef] <asn:2>*[noderef] <asn:3>*<noident>

How is that related to this patch?

	M.
-- 
Jazz is not dead. It just smells funny.

  reply	other threads:[~2017-07-16 20:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-16 17:40 [PATCH] irqchip/gic: Use GIC_SPI symbolic constant Mason
2017-07-16 20:13 ` Marc Zyngier [this message]
2017-07-16 20:50   ` Mason
2017-07-16 21:08     ` Marc Zyngier
2017-07-16 21:29       ` Mason
2017-07-17  8:07       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86shhwywas.fsf@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox