From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6C7ACD4F5B for ; Tue, 19 May 2026 07:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G3ch9SiAu8JeK6AIOkkgr9+s9uvzOQgUd95KnYuVQ84=; b=W3bw1l8ycTZMkOkZpAKs2iZhuX 8ztSJtjh3CZKxbZw2qEaiD7C6YTHQpxHG7B9XwogwZOqLl2PwI7mEqem+wxZ1Oed0FahGWW7y1eoq 3SVkE6vV94ntokgBMTquYiv01qbwXPmEkkjwXb/nT2IzdkJVyhnykfeM9KMiK51N/ZGjjhMlR3sPm EaN0IQpksHDsVFWqYOuP6AwB5GJuv7pLD9hVr9keuX5aFJhZyDs38h1cOp0CQTCTaXMymM/hrZksQ 26K75gJI6FV3+2NQqjVpfQ/T0A2KKWUtbyokC4v7ctuV8gTJcUJX0LpH1UFTvS/r95sMQI662dLOP N7qpGDhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPFH9-00000000ZVz-0E6X; Tue, 19 May 2026 07:54:03 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPFH6-00000000ZVM-2kgQ for linux-arm-kernel@lists.infradead.org; Tue, 19 May 2026 07:54:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E5C7C43F8E; Tue, 19 May 2026 07:53:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F2AC2BCB3; Tue, 19 May 2026 07:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779177239; bh=dE1+5CTzbd3ruwSwP8Km4ilvTVIBMQhESJGdZiggQi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y0ENtzoe4SvmuJQ3CilFHTbmlNa15I5+Oaw3k9Ddjw+Fq+CmhOi8EDHe5vhUFzjzu 4nGyHfS2QdvcVf81R5I13sTkIwdcQdpX3TNrJXZN9XmuoVQlfrXphttBN4475DnR4W JUw0biK/q5Cfuf4CNx9g5O6CGnI88qiRSavRAGw9FjKhpyL4boRYNL0h2Xm9a4smaK potBWRIs/y7qDvjfpRdTllIp22ovZTEs9cpkYqwSuBusk0f8KsH9lznSgQMj8OdLZ3 W1yGjIFWbzZRcZGH86Aa6WqDQ9nKDXFPI4efgB5FXzirK2i0SUTbDkwwJYsYltblcz hnuq04ZQCeFOw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wPFH3-00000003poq-0yUd; Tue, 19 May 2026 07:53:57 +0000 Date: Tue, 19 May 2026 08:53:56 +0100 Message-ID: <86tss3x2az.wl-maz@kernel.org> From: Marc Zyngier To: Michael Bommarito Cc: Yao Yuan , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic: free private_irqs when init fails after allocation In-Reply-To: References: <20260517181331.367676-1-michael.bommarito@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: michael.bommarito@gmail.com, yaoyuan@linux.alibaba.com, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_005400_712725_C0D6471E X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 May 2026 01:26:58 +0100, Michael Bommarito wrote: >=20 > On Mon, May 18, 2026 at 1:31=E2=80=AFAM Yao Yuan wrote: > > Ah. One thing I forgot to say: > > > > Do we need a fixes: tag here ? >=20 > I struggled with that a bit. Will's sister commit in 250f25367b58 > didn't have a Fixes: tag, but if I had to pick, it would probably be > this: > Fixes: 03b3d00a70b5 ("KVM: arm64: vgic: Allocate private interrupts on de= mand") >=20 > If you agree, I can send v2 with that added Seems correct to me. Please send v2 at your earliest convenience with a trimmed commit message (potentially limited to the first paragraph). Thanks, M. --=20 Without deviation from the norm, progress is not possible.