From: Marc Zyngier <maz@kernel.org>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Sascha Bischoff <sascha.bischoff@arm.com>,
Timothy Hayes <timothy.hayes@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path
Date: Fri, 01 Aug 2025 13:26:42 +0100 [thread overview]
Message-ID: <86tt2r6xdp.wl-maz@kernel.org> (raw)
In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-1-4fcedaccf9e6@kernel.org>
On Fri, 01 Aug 2025 08:58:18 +0100,
Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
>
> Kbot reported that on the failure path the driver
> iounmap() IWB resources that are managed through
> devm_ioremap(), which is clearly wrong because
> the driver would end up unmapping the MMIO
> resource twice on probing failure.
>
> Fix this by removing the error path altogether
> and by letting devres manage the iounmapping
> on clean-up.
>
> Fixes: 695949d8b16f ("irqchip/gic-v5: Add GICv5 IWB support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508010038.N3r4ZmII-lkp@intel.com
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <maz@kernel.org>
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-08-01 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 7:58 [PATCH 0/3] irqchip/gic-v5: Minor clean-ups/fixes Lorenzo Pieralisi
2025-08-01 7:58 ` [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path Lorenzo Pieralisi
2025-08-01 12:26 ` Marc Zyngier [this message]
2025-08-01 7:58 ` [PATCH 2/3] irqchip/gic-v5: iwb: Remove module boilerplate Lorenzo Pieralisi
2025-08-01 12:24 ` Marc Zyngier
2025-08-01 14:04 ` Lorenzo Pieralisi
2025-08-01 7:58 ` [PATCH 3/3] irqchip/gic-v5: Remove IRQD_RESEND_WHEN_IN_PROGRESS for ITS IRQs Lorenzo Pieralisi
2025-08-01 12:30 ` Marc Zyngier
2025-08-01 14:01 ` Lorenzo Pieralisi
2025-08-05 9:30 ` [PATCH 0/3] irqchip/gic-v5: Minor clean-ups/fixes Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tt2r6xdp.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=sascha.bischoff@arm.com \
--cc=tglx@linutronix.de \
--cc=timothy.hayes@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).