From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF755C87FD2 for ; Fri, 1 Aug 2025 13:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UCfFfYLLacgTiqtgVh9KyngzJu3Ciuc4AtiXszph8Zo=; b=GSIaBwn69yBbZaIGBmLOjEgnZi 3J+eV9n9UTLZnE7DglKYPDVlSRpjYvu3xnW4YU/mOXGk8Ve+hE/e9ZkA3ZUjFpnp7OcCxfMziNCqW Eybd6aCzfOUlZFbwtVQ4x1zGvv08Klf3NHSuhAPOTvGW7CKOKXYu9p5uxHEIt2WJnCBiWOO4CA6Lz s9FJ5b3Dm+z77naNq141MLWZsfVNRWH655HcUIHhmUgqxUf8j5sEO3avi0LtcN6/w3yfEmszdvLvm 9tEwn9gIfWjMDnqeWBx9vR9C1NAWMuu1AXAKJJaq78OrOrabgcC1CLikvH/N9PGqZUZTlTbFVDAt3 WTFhBsqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uhpTm-000000063n8-3q0S; Fri, 01 Aug 2025 13:07:22 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uhoqV-00000005tDi-2SJX for linux-arm-kernel@lists.infradead.org; Fri, 01 Aug 2025 12:26:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E7F7B43680; Fri, 1 Aug 2025 12:26:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C47EEC4CEE7; Fri, 1 Aug 2025 12:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754051206; bh=54omA8gQjQ0nB3x6U7tnPOT4PBWXGy4soqSWYNK0+ks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P0n6ciKfDp3a+nZAH31xqpZfMLuq7M7ajQS/LqXvKygMG/NdOQzeOaBTCXo9lu5qF FXQC8qjQh7Y7HDtdYrRm7vcDOiV6Vm0Ii2xt6VVkpAUQxUhkI06UFdGDD7UreVJ+L+ ZSDNWLjAGbtUWj14sdjOLMbBQgECeCDkLbEp50qkMYr7XXkgpTxYOoyMbmmA6Mtjvp IpeHOnOw08oZ3uNfRHCJdl8ufJ91nfDf6XYdcguJg3T11Jm0Hj2IafzisiCoZegCyZ 4nnJTcqCPUV/hVawtZIJ0EHD7OfrbS6MfSoSHzgg4gNpg48kLTcQwMat7tjnVg9Zoe 14TBCY0bJGNpA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uhoqS-003C3U-Ds; Fri, 01 Aug 2025 13:26:44 +0100 Date: Fri, 01 Aug 2025 13:26:42 +0100 Message-ID: <86tt2r6xdp.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Thomas Gleixner , Sascha Bischoff , Timothy Hayes , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-1-4fcedaccf9e6@kernel.org> References: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> <20250801-gic-v5-fixes-6-17-v1-1-4fcedaccf9e6@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, tglx@linutronix.de, sascha.bischoff@arm.com, timothy.hayes@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lkp@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250801_052647_655177_7A074074 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 01 Aug 2025 08:58:18 +0100, Lorenzo Pieralisi wrote: > > Kbot reported that on the failure path the driver > iounmap() IWB resources that are managed through > devm_ioremap(), which is clearly wrong because > the driver would end up unmapping the MMIO > resource twice on probing failure. > > Fix this by removing the error path altogether > and by letting devres manage the iounmapping > on clean-up. > > Fixes: 695949d8b16f ("irqchip/gic-v5: Add GICv5 IWB support") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202508010038.N3r4ZmII-lkp@intel.com > Signed-off-by: Lorenzo Pieralisi > Cc: Thomas Gleixner > Cc: Marc Zyngier Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.