From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80C66C77B7F for ; Fri, 27 Jun 2025 13:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r0D2tpVwY96S3FE+H3g47JhCwEM6XUg0WUzfF2FzvOU=; b=4Yi0nnA2djE743XrFJjP6SKom5 jJk/9z2HjKctYD/lKWuGg6KEbX1xjowTiIUHNlPTkGsZIoTU3lLDtUqTYrzbsq2MvZyXwSKz0I3ZY cjqIj5M1spP0kGFpKp/oTW7V8c028sPrwtc0HDlSujqgElmRQgxtyhTM9eovpWdtYdLKMlOgL4sRq IsIyK2kzfGCmUC4PhX6rVbu0w44WDs9fByAJ0BXSXJ7+It/nzc3DbdejnKh8rbl2dWQ9ZbJigbMBA 0C/SYx+FUzfuP0eD6lu7hAuIwuJV+MW3ezyzqivvuqUiIhWtW32vfdbIOmAfOUfOBq6kiXY1NSKMY ingP1ifA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uV9b3-0000000EqNP-2CAZ; Fri, 27 Jun 2025 13:58:29 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uV92w-0000000ElKf-0JuI for linux-arm-kernel@lists.infradead.org; Fri, 27 Jun 2025 13:23:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9A6DD434A7; Fri, 27 Jun 2025 13:23:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F526C4CEE3; Fri, 27 Jun 2025 13:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751030593; bh=JIWvjEsAlcLjXPQ5Hbwf/8w/8yueo94WJUdb35S5Oec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vOYFNiTvT+uN16eqP2YsWAm8KNoGDrAGRnGCZQ6k3cO3wSmWrl36/2ZlQcLJQwrRv x0ukPV/wQEOdYQ2i6vAzxBPDpSXvXf3bfojfbaXAGUi/zOjkFrXqpF4lL5XnmLTOA8 JVICb6C+MRm1Siz8dIurqz6weeho1YZXN5VTyqQEoGulA/8dV9I2M2O6Lh80RiFBlv a8PqNGgBVGPdfZSr5Bsa2an5D5s9mwpT/qmHwp6N2Dnb8r+rq0pfYtC4MB++kkgB64 exk69s0EgLMe7xEvIINLL9QNOlx2iQzFmmNXVv1jZa2st1kUxL05Mes900+mRzbxlL UwcCAULbWT0Qw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uV92s-00AZW6-S1; Fri, 27 Jun 2025 14:23:10 +0100 Date: Fri, 27 Jun 2025 14:23:10 +0100 Message-ID: <86tt41b9oh.wl-maz@kernel.org> From: Marc Zyngier To: Colton Lewis Cc: kvm@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Russell King , Catalin Marinas , Will Deacon , Oliver Upton , Mingwei Zhang , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Mark Rutland , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 02/22] arm64: Generate sign macro for sysreg Enums In-Reply-To: <20250626200459.1153955-3-coltonlewis@google.com> References: <20250626200459.1153955-1-coltonlewis@google.com> <20250626200459.1153955-3-coltonlewis@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: coltonlewis@google.com, kvm@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, mizhang@google.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, shuah@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250627_062314_138617_39DE5E6D X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 Jun 2025 21:04:38 +0100, Colton Lewis wrote: > > There's no reason Enums shouldn't be equivalent to UnsignedEnums and > explicitly specify they are unsigned. This will avoid the annoyance I > had with HPMN0. And randomly break unsuspecting cases for which a value is neither signed not unsigned, but an actual *enumeration*. If you have issues with HPMN0, start by explaining those, because ranting in a commit message doesn't help much. M. -- Without deviation from the norm, progress is not possible.