From: Marc Zyngier <maz@kernel.org>
To: Donghyeok Choe <d7271.choe@samsung.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Youngmin Nam <youngmin.nam@samsung.com>,
Thomas Gleixner <tglx@linutronix.de>,
Saravana Kannan <saravanak@google.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
hajun.sung@samsung.com, joonki.min@samsung.com,
ne.yoo@samsung.com
Subject: Re: [GICv3 ITS]S2IDLE framework does not invoke syscore_ops in GICv3 ITS driver
Date: Tue, 08 Apr 2025 07:51:32 +0100 [thread overview]
Message-ID: <86tt6zkux7.wl-maz@kernel.org> (raw)
In-Reply-To: <20250407225146.GA2858456@tiffany>
On Mon, 07 Apr 2025 23:51:46 +0100,
Donghyeok Choe <d7271.choe@samsung.com> wrote:
>
> [1 <text/plain; us-ascii (7bit)>]
> On Mon, Apr 07, 2025 at 10:17:43AM +0100, Sudeep Holla wrote:
> > Do you use any suspend/resume logic in drivers/irqchip/irq-gic-pm.c ?
> No, there are parts of the GIC that require secure access, so the
> GIC save/restore is performed by the firmware.
> Since the GIC-ITS is entirely controlled as a non-secure IP,
> I think it is more efficient to perform save/restore in the kernel.
More efficient? Give me *one* aspect of this save/restore sequence
that is done in a more efficiently way in the kernel. Dumping MMIO
accesses into memory has the exact same cost at EL1, El2 or EL3, and
splitting things along an arbitrary line to paper over bad firmware is
not a valid argument.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-04-08 6:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250326030527epcas2p33aa30e62cc8a00c9e151c35bee71dac5@epcas2p3.samsung.com>
[not found] ` <Z+Nv8U/4P3taDpUq@perf>
2025-03-26 8:59 ` [GICv3 ITS]S2IDLE framework does not invoke syscore_ops in GICv3 ITS driver Marc Zyngier
2025-03-27 3:22 ` Youngmin Nam
2025-03-27 8:25 ` Marc Zyngier
2025-03-28 2:10 ` Youngmin Nam
2025-04-01 12:45 ` Ulf Hansson
2025-04-01 13:11 ` Marc Zyngier
2025-04-02 10:57 ` Ulf Hansson
2025-04-03 7:16 ` Marc Zyngier
2025-04-02 11:56 ` Sudeep Holla
2025-04-03 1:30 ` Youngmin Nam
2025-04-03 9:18 ` Sudeep Holla
2025-04-04 4:13 ` Donghyeok Choe
2025-04-07 9:17 ` Sudeep Holla
2025-04-07 22:51 ` Donghyeok Choe
2025-04-08 6:51 ` Marc Zyngier [this message]
2025-04-08 22:28 ` Donghyeok Choe
2025-04-08 10:46 ` Sudeep Holla
2025-04-08 22:11 ` Donghyeok Choe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tt6zkux7.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=d7271.choe@samsung.com \
--cc=hajun.sung@samsung.com \
--cc=joonki.min@samsung.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ne.yoo@samsung.com \
--cc=saravanak@google.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).