From: Marc Zyngier <maz@kernel.org>
To: Ma Ke <make24@iscas.ac.cn>
Cc: tglx@linutronix.de, Suravee.Suthikulpanit@amd.com,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
Date: Tue, 20 Aug 2024 10:54:56 +0100 [thread overview]
Message-ID: <86ttffy0wf.wl-maz@kernel.org> (raw)
In-Reply-To: <20240820092843.1219933-1-make24@iscas.ac.cn>
On Tue, 20 Aug 2024 10:28:43 +0100,
Ma Ke <make24@iscas.ac.cn> wrote:
>
> We fail to perform an of_node_put() when of_address_to_resource()
> fails, leading to a refcount leak.
>
> Address this by moving the error handling path outside of the loop and
> making it common to all failure modes.
>
> Cc: stable@vger.kernel.org
> Fixes: 4266ab1a8ff5 ("irqchip/gic-v2m: Refactor to prepare for ACPI support")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2024-08-20 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 9:28 [PATCH v3] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init Ma Ke
2024-08-20 9:54 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttffy0wf.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).