From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 714F3C25B75 for ; Fri, 31 May 2024 09:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DmENyCrx53JuSm+n6+CbYl5sh//XbwZc0MkCd0aSgj8=; b=sP34rmIwB94RYv kr91cMLaHVnLYxCqbFl+qPkH/QgmDrouC/LhI0VZoyCh7FZiyJoUT8RqzgzgcBlHTIEbv7VpuPQWe MRN1j/bW6zgfyWNRT8t8HzV6R01GEmuXDCmstSQHoCcsXUy8anex9G4LuJgBMZZcBPA46RRv1FTv3 iocXfGTUgobj5zzBvkzgupRLTeXFfPzYESAvRSqF66jCtbkXMeJEg85jaMBeeWXtWR8r2N9ZSX8cc LMPxknbxQeo3HqBfHiFnVylwfxa41UKEkcIaU74tEw45SVcahypTniHAW+YG5svua3es2vHBJIT9Y P99DahUg73f2TleRdBIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCyXZ-00000009nKJ-0zGG; Fri, 31 May 2024 09:27:13 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCyXU-00000009nJS-2cak for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2024 09:27:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 26FEE629A1; Fri, 31 May 2024 09:27:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1450C116B1; Fri, 31 May 2024 09:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717147626; bh=a7wmDqmUfEy4sWh4SogWxUyxjOiHWPHOFeUWeU5qm9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s15xrfFBXLLa2OztA12J9cnSuK2dOlgh+od2sYYyavwU33qQ78WmvBa0HEUaDWP91 4yuOGl4/jwg2hP44S7KlhweiIDfe0f8fD34F21730fL6gKBTZSU2b/FF4M77w0ZK6a 2HZBPZWgqptJKEzdK0XVksSPVvs6YBgWWUcbZEGjkzez1BGf3MKqaem5SuTO9l4/6y N2kr97V2NUfm1wlUPnXD/wvIdujAp0LVXrf4EyegofsVMA1dLBqNQ1FiM+p0/HizOl 2DK6CXaFF7n4Cpdlx/+6xlU3cJgQhmcTE+A3ZAv4VpdToWYLueaIWlg8jLIyniV5Cb XoYwT2nOWI0ug== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCyXQ-00H83j-Fj; Fri, 31 May 2024 10:27:04 +0100 Date: Fri, 31 May 2024 10:27:04 +0100 Message-ID: <86ttiel4bb.wl-maz@kernel.org> From: Marc Zyngier To: Hagar Hemdan Cc: Maximilian Heyne , Norbert Manthey , "Thomas\ Gleixner" , Eric Auger , , Subject: Re: [PATCH v2] irqchip/gic-v3-its: Fix potential race condition in its_vlpi_prop_update() In-Reply-To: <20240531074302.30563-1-hagarhem@amazon.com> References: <20240531074302.30563-1-hagarhem@amazon.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: hagarhem@amazon.com, mheyne@amazon.de, nmanthey@amazon.de, tglx@linutronix.de, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240531_022708_749439_C0F32637 X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 31 May 2024 08:43:02 +0100, Hagar Hemdan wrote: > > its_vlpi_prop_update() calls lpi_write_config() which obtains the > mapping information for a VLPI without lock held. So it could race > with its_vlpi_unmap(). > Since all calls from its_irq_set_vcpu_affinity() require the same > lock to be held. So instead of peppering the locking all over the > place, we hoist the locking into its_irq_set_vcpu_affinity(). > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Fixes: 015ec0386ab6 ("irqchip/gic-v3-its: Add VLPI configuration handling") > Signed-off-by: Hagar Hemdan Given that you have lifted both my proposed patch and part of my reply as a commit message, you may at least credit me with a Suggested-by: tag. Not to mention that the blatant advertising doesn't really apply in this case. > --- > v2: moved the lock to its_irq_set_vcpu_affinity(). > Only compile-tested, no access to HW. Was the initial patch tested at all? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel