From: Marc Zyngier <maz@kernel.org>
To: "Li,Rongqing" <lirongqing@baidu.com>
Cc: "oliver.upton@linux.dev" <oliver.upton@linux.dev>,
"james.morse@arm.com" <james.morse@arm.com>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"yuzenghui@huawei.com" <yuzenghui@huawei.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>
Subject: Re: [PATCH] KVM: arm64: Consider NUMA affinity when allocating per-CPU stack_page
Date: Thu, 18 Apr 2024 10:03:24 +0100 [thread overview]
Message-ID: <86ttjzqbz7.wl-maz@kernel.org> (raw)
In-Reply-To: <f5228e62a05c45a7a61698caa0543485@baidu.com>
On Thu, 18 Apr 2024 07:53:58 +0100,
"Li,Rongqing" <lirongqing@baidu.com> wrote:
> > Li RongQing <lirongqing@baidu.com> wrote:
> > >
> > > per-CPU stack_page are dominantly accessed from their own local CPUs,
> > > so allocate them node-local to improve performance.
> >
> > Do you have any performance data to back this up?
> >
> > Given that this is only used in the non-VHE case, and that by doing so you have
> > left quite a lot of performance on the floor already, I'm even more surprised to
> > see the performance argument.
> >
>
> Sorry, I have not setup to test it.
>
> > Furthermore, you don't address the allocation of per-CPU data, which has a
> > much larger potential impact, given how the HYP code is structured.
> >
>
> I will add it in V2
Please test your patch before posting it. I'm not interested in
looking at patches that have not been tested by their author.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-04-18 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 3:36 [PATCH] KVM: arm64: Consider NUMA affinity when allocating per-CPU stack_page Li RongQing
2024-04-15 7:36 ` Marc Zyngier
2024-04-18 6:53 ` Li,Rongqing
2024-04-18 9:03 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttjzqbz7.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lirongqing@baidu.com \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).