From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B537C4345F for ; Thu, 18 Apr 2024 09:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MCUEPkhuuo8GIMy71r2E4jN+PSKeax6SmNN/YsHJcAM=; b=o2p3u60KodRsIw U7BkZSY3PVUD3ar1WhzGxFOneb7bBpeAMlbBsf7b5ZYMD14lDpzu0JaAzuUgh0EGdskQyV2Xx/vBH fIcFiVGp+wO9xbs4mXCWtHzJC0RDs0hmyjjQRSRxHneq3i+D3ea8xDn7K5GljOOhthAuhxlDWQzs1 8lJPHSpucsmyKv0rpusiJ+nyJlUkDrNIqa3RlM+6dUnJhMy8cb4uIcy6obA79ox4aqVGl4OiWFi8w wcD0TMZ0B7JXFLjnOI5LKxg+ZSKZ1VvJo+Tv92F//nkDDtJ23KukD5zXNsnGDaOBCNr1ue0Wp7r8I msEjgkSyQY5a8bXUvMMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxNg9-00000001XQg-39e1; Thu, 18 Apr 2024 09:03:37 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxNg1-00000001XPy-3xBi for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 09:03:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2E15ACE12DC; Thu, 18 Apr 2024 09:03:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5867AC113CC; Thu, 18 Apr 2024 09:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713431007; bh=fZLlEF0YgIqSbFU5U1nYxSh/tnzuhkrPDKtAgNrLJ94=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d5xFKJqWTepXuop6eeJ2+o7MznxL+ZMTbeU05xbD9GjnW7YaWlKtP2jiPRAnMs7o5 Tk7FGvO84oJuFpVaXWMibwlayZRLoPErEPWYchUhxR0Q7WaxUqyVTTu4g5TSMewPjs 17iQnSWwIQBaSUyVaxs0JEtNzZIgqx032ir3WC5Gg+8tJje1pgXw/IfOp2grXYgLrk Iij6TVQk2Kw5oI2jsyJqG8aqTzAN/n/aVIFP1Kn8xRsU0EFojfY4bgmeWSk2C/KXWe l8DxTunjbutkirFgwr4Ah56VoU3WAItNZcV5+k/FMzrqTtfigNYHtO9PMFnvq0iJ07 hr6YP6UJVcgAw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rxNfw-005frc-D2; Thu, 18 Apr 2024 10:03:24 +0100 Date: Thu, 18 Apr 2024 10:03:24 +0100 Message-ID: <86ttjzqbz7.wl-maz@kernel.org> From: Marc Zyngier To: "Li,Rongqing" Cc: "oliver.upton@linux.dev" , "james.morse@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" Subject: Re: [PATCH] KVM: arm64: Consider NUMA affinity when allocating per-CPU stack_page In-Reply-To: References: <20240415033614.43518-1-lirongqing@baidu.com> <86bk6brsb5.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lirongqing@baidu.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_020330_196155_92BB94FF X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 Apr 2024 07:53:58 +0100, "Li,Rongqing" wrote: > > Li RongQing wrote: > > > > > > per-CPU stack_page are dominantly accessed from their own local CPUs, > > > so allocate them node-local to improve performance. > > > > Do you have any performance data to back this up? > > > > Given that this is only used in the non-VHE case, and that by doing so you have > > left quite a lot of performance on the floor already, I'm even more surprised to > > see the performance argument. > > > > Sorry, I have not setup to test it. > > > Furthermore, you don't address the allocation of per-CPU data, which has a > > much larger potential impact, given how the HYP code is structured. > > > > I will add it in V2 Please test your patch before posting it. I'm not interested in looking at patches that have not been tested by their author. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel