From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67D80EB64DA for ; Tue, 4 Jul 2023 14:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ebjqYDunyJG68HCjTXObPXfBhYet0vuxwnJY18+zaM=; b=WWH+EGIEkcdddR +Cu5oPOUaZijuB84FdjQTsEtYF/XqK5oLeEmz2TxHMCNqolH0cr2ZiZaZDgMqjtYob18vPIW3+au9 3DrLo0KhyM5yyinYwpKMNzG73e5A1N0aJretCBvvAV5ZGBPTNtk7a8ZTekTUcuEX8nq0OvALbXA4w /uNmJd6Oitl8EbxtbQOsasUTu7cnwtRy+Ql3AlS7keN1dUqbJjyEWsZkW7P0LjroYQx7vEQEMooEV k3zySrJe8KXcZzI7vYoUjqBkxjNlT0ErPR5CAc8xryvWCwaGcPsz96BzHHzy9isVAJ2Mmm6NoV3Ih u3ZhMdYSerfLqvm0YEJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGhH0-00DY15-1G; Tue, 04 Jul 2023 14:44:58 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGhGw-00DY0F-2E for linux-arm-kernel@lists.infradead.org; Tue, 04 Jul 2023 14:44:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78E1F6117F; Tue, 4 Jul 2023 14:44:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E14A3C433C7; Tue, 4 Jul 2023 14:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688481892; bh=lxhuBwB0JRbnb5pA0aXShpARIqzZaHCZ0lxC4k4Ng+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B1dxsGnjE3f9KhDfugOBUuNnqJdOOJgn8GJPek9hQUzRWwQrJRJBwo2Pl5MSpfzeP YgjlY3sAorwyAtvNEMD1LVXKDg3a8xNRIxU2AfRNKZ73JGbGfrNLqVj6mi5ANk6Y/6 kommWkCZTx3j4cddtI9ZC3Ojl6+HJceiIZQLFM2C/3s20P+y+yHnjut0X2jhLC5d6F djf/aFTuX8QMNshBzRS3byLHeOSqrDXWgMx6GF4lp4CWWanhEQ13tmg4a13r9VrgJh 76I5oMStMOPlUZmEMEcKdQ5hso45ehhfuSMVXr0JoKIPBVPyXl/Z/fS9+1mUSIh7rj XeHGmMe9+E5SA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qGhGs-00ASU6-Eo; Tue, 04 Jul 2023 15:44:50 +0100 Date: Tue, 04 Jul 2023 15:44:50 +0100 Message-ID: <86ttujwxb1.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-arm-kernel@lists.infradead.org, Hanks Chen , Cheng-Yuh.Wu@mediatek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip/gic-v3: Workaround for GIC-700 erratum 2941627 In-Reply-To: <20230704123436.127449-1-lpieralisi@kernel.org> References: <20230704123436.127449-1-lpieralisi@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, hanks.chen@mediatek.com, Cheng-Yuh.Wu@mediatek.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_074454_842367_2DC4688F X-CRM114-Status: GOOD ( 41.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Lorenzo, On Tue, 04 Jul 2023 13:34:36 +0100, Lorenzo Pieralisi wrote: > > GIC700 erratum 2941627 may cause GIC-700 missing SPIs wake > requests when SPIs are deactivated while targeting a > sleeping CPU - ie a CPU for which the redistributor: > > GICR_WAKER.ProcessorSleep == 1 > > This runtime situation can happen if an SPI that has been > activated on a core is retargeted to a different core, it > becomes pending and the target core subsequently enters a > power state quiescing the respective redistributor. > > When this situation is hit, the de-activation carried out > on the core that activated the SPI (through either ICC_EOIR1_EL1 > or ICC_DIR_EL1 register writes) does not trigger a wake > requests for the sleeping GIC redistributor even if the SPI > is pending. > > Fix the erratum by de-activating the SPI using the s/Fix/ Work around/ > redistributor GICD_ICACTIVER register if the runtime > conditions require it (ie the IRQ was retargeted between > activation and de-activation). > > Signed-off-by: Lorenzo Pieralisi > Cc: Marc Zyngier > --- > Documentation/arm64/silicon-errata.rst | 3 ++ > drivers/irqchip/irq-gic-v3.c | 71 +++++++++++++++++++++++++- > 2 files changed, 73 insertions(+), 1 deletion(-) > > diff --git a/Documentation/arm64/silicon-errata.rst b/Documentation/arm64/silicon-errata.rst > index 9e311bc43e05..e77c57a0adf8 100644 > --- a/Documentation/arm64/silicon-errata.rst > +++ b/Documentation/arm64/silicon-errata.rst > @@ -141,6 +141,9 @@ stable kernels. > | ARM | MMU-500 | #841119,826419 | N/A | > +----------------+-----------------+-----------------+-----------------------------+ > +----------------+-----------------+-----------------+-----------------------------+ > +| ARM | GIC-700 | #2941627 | ARM64_ERRATUM_2941627 | > ++----------------+-----------------+-----------------+-----------------------------+ > ++----------------+-----------------+-----------------+-----------------------------+ > | Broadcom | Brahma-B53 | N/A | ARM64_ERRATUM_845719 | > +----------------+-----------------+-----------------+-----------------------------+ > | Broadcom | Brahma-B53 | N/A | ARM64_ERRATUM_843419 | > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index a605aa79435a..a0a9ccf23742 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -68,6 +68,8 @@ struct gic_chip_data { > static void __iomem *t241_dist_base_alias[T241_CHIPS_MAX] __read_mostly; > static DEFINE_STATIC_KEY_FALSE(gic_nvidia_t241_erratum); > > +static DEFINE_STATIC_KEY_FALSE(gic_arm64_2941627_erratum); > + > static struct gic_chip_data gic_data __read_mostly; > static DEFINE_STATIC_KEY_TRUE(supports_deactivate_key); > > @@ -591,10 +593,35 @@ static void gic_irq_nmi_teardown(struct irq_data *d) > gic_irq_set_prio(d, GICD_INT_DEF_PRI); > } > > +static bool gic_arm64_erratum_2941627_needed(struct irq_data *d) > +{ > + if (!static_branch_unlikely(&gic_arm64_2941627_erratum)) > + return false; > + > + /* > + * The workaround is needed if the IRQ is an SPI and > + * the target cpu is different from the one we are > + * executing on. > + */ > + return !((gic_irq_in_rdist(d)) || gic_irq(d) >= 8192 || > + cpumask_equal(irq_data_get_effective_affinity_mask(d), > + cpumask_of(smp_processor_id()))); I dislike this statement for multiple reasons: - it is written as a negation, making it harder than strictly necessary to parse as it is the opposite of the comment above - gic_irq_in_rdist() and gic_irq(d) >= 8192 are two ways of checking the interrupt range -- maybe we should just do that - cpumask_equal() is *slow* if you have more that 64 CPUs, something that is increasingly common -- a better option would be to check whether the current CPU is in the mask or not, which would be enough as we only have a single affinity bit set - smp_processor_id() can check for preemption, which is pointless here, as we're doing things under the irq_desc raw spinlock. I would expect something like: enum gic_intid_range range = get_intid_range(d); return (range == SGI_RANGE || range == ESPI_RANGE) && !cpumask_test_cpu(raw_smp_processor_id(), irq_data_get_effective_affinity_mask(d)); > +} > + > static void gic_eoi_irq(struct irq_data *d) > { > write_gicreg(gic_irq(d), ICC_EOIR1_EL1); > isb(); > + > + if (gic_arm64_erratum_2941627_needed(d)) { > + /* > + * Make sure the GIC stream deactivate packet > + * issued by ICC_EOIR1_EL1 has completed before > + * deactivating through GICD_IACTIVER. > + */ > + dsb(sy); > + gic_poke_irq(d, GICD_ICACTIVER); > + } > } > > static void gic_eoimode1_eoi_irq(struct irq_data *d) > @@ -605,7 +632,11 @@ static void gic_eoimode1_eoi_irq(struct irq_data *d) > */ > if (gic_irq(d) >= 8192 || irqd_is_forwarded_to_vcpu(d)) > return; > - gic_write_dir(gic_irq(d)); > + > + if (!gic_arm64_erratum_2941627_needed(d)) > + gic_write_dir(gic_irq(d)); > + else > + gic_poke_irq(d, GICD_ICACTIVER); > } > > static int gic_set_type(struct irq_data *d, unsigned int type) > @@ -1796,6 +1827,25 @@ static bool gic_enable_quirk_nvidia_t241(void *data) > return true; > } > > +static bool gic_enable_quirk_arm64_2941627(void *data) > +{ > + /* > + * If CPUidle is not enabled the erratum runtime > + * conditions can't be hit, since that requires: > + * > + * - A core entering a deep power state with > + * the associated GIC redistributor asleep > + * and an IRQ active and pending targeted at it > + * - A different core handling the IRQ and > + * related GIC operations at the same time > + */ > + if (!IS_ENABLED(CONFIG_CPU_IDLE)) > + return false; Could this still hit on a system that traps WFI to EL3 and uses this as a way to enter a low-power mode? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel