From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B95A5C5AD55 for ; Mon, 10 Aug 2026 11:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+WUQmunuAHmUFO6LakZVc7vewqsfFce18N0HbJ03AJY=; b=RIpIhdTWppu49+8DAiquivDEua T0eTnxmLNj+2ccORtrXMj9PiKYnbaNDprp/cotWptb8DgROpZLPq/galVkEuki4P4dT+jDXY6ciS/ Ngb40vrxT6dpC0C9tkybJz4GCjlmlvIn81mbieQ3zifGcz5t0yy7UOC2s/ivvbZ7HAJHqbZN3u4cy WOI0sXtUyhGc4bYZGyKQxnJNeZqPO0YX6fNxtOAZ8fDPj0dlQekiqtloMi7bNtEhmE+ajJvF3O3wM i2uz73IfwuQ0QuXpELFdkNz8UTYjT0ihF/Qbuh+z5p5Bh6DJz4TN3KnbuKycjRoJBqS7CbYUU3Fyu 46uOlEbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtOFW-0000000BdIw-2VmX; Mon, 10 Aug 2026 11:32:58 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtOFV-0000000BdIq-3efm for linux-arm-kernel@lists.infradead.org; Mon, 10 Aug 2026 11:32:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5153B600DA; Mon, 10 Aug 2026 11:32:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 058671F000E9; Mon, 10 Aug 2026 11:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786361577; bh=+WUQmunuAHmUFO6LakZVc7vewqsfFce18N0HbJ03AJY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bCpzli4pKk0jcdIZyFhrTY2Le3Y/aU/b80NAjqMtcwwd/BpCO2tm0p8Xrsn1A2RB4 xaZyNywK+uaDui0S+FKo62Ztx+3KsyS7PvQPSO8cyNy9zGDrm3+/kAvECy6whPae9f rEd6BXmrDAlmWzpTRyAd2R1fTFblPP+lwl8ytMUJABA5FQ2FEigj/418cFuhZa1sJy XMktKWwJKPYA6LJjD3T4iwDUwRSADszelTWkrpDiRmVtohNM7EZkfSS7KQXBYMq+8p Js+GqpTP9OG0kx9T0/VIcu7oMWlO2w4Yi+N7JBox1RJBPBnclm3WtncEyfWMlGDSUE PykIIzsEz+5SA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wtOFT-0000000E4kX-0fxH; Mon, 10 Aug 2026 11:32:55 +0000 Date: Mon, 10 Aug 2026 12:32:54 +0100 Message-ID: <86v79i1a8p.wl-maz@kernel.org> From: Marc Zyngier To: Kajetan Puchalski Cc: oupton@kernel.org, fuad.tabba@linux.dev, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, jic23@kernel.org, Sascha.Bischoff@arm.com, zenghui.yu@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic: Fix detection of MI on no pending LR In-Reply-To: <20260810102923.2426475-2-kajetan.puchalski@arm.com> References: <20260810102923.2426475-2-kajetan.puchalski@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kajetan.puchalski@arm.com, oupton@kernel.org, fuad.tabba@linux.dev, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, jic23@kernel.org, Sascha.Bischoff@arm.com, zenghui.yu@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, stable@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [Fixing up the initial recipient list...] On Mon, 10 Aug 2026 11:29:24 +0100, Kajetan Puchalski wrote: > > As per the ARM GICv3 spec, the maintenance interrupt identified by > ICH_MISR_EL2.NP is asserted when it is enabled and no List register is > in pending state. This is further described in the document as "no List > registers with the State field set to 0b01 (pending)". By checking only > the pending bit of the LR (bit 62), KVM currently asserts the MI when > there are no LRs in "pending" or "pending and active" states. > Fix the detection logic to consider only the "pending" state. > > Cc: stable@vger.kernel.org > Fixes: 96c2f03311de ("KVM: arm64: nv: Plumb handling of GICv3 EL2 accesses") > Signed-off-by: Kajetan Puchalski > --- > arch/arm64/kvm/vgic/vgic-v3-nested.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-v3-nested.c b/arch/arm64/kvm/vgic/vgic-v3-nested.c > index 5c69fa615823..e3e84d7f5ad5 100644 > --- a/arch/arm64/kvm/vgic/vgic-v3-nested.c > +++ b/arch/arm64/kvm/vgic/vgic-v3-nested.c > @@ -152,7 +152,7 @@ static void vgic_compute_mi_state(struct kvm_vcpu *vcpu, struct mi_state *mi_sta > eisr |= BIT(i); > if (!(lr & ICH_LR_STATE)) > elrsr |= BIT(i); > - pend |= (lr & ICH_LR_PENDING_BIT); > + pend |= (lr & ICH_LR_STATE) == ICH_LR_PENDING_BIT; > } > > mi_state->eisr = eisr; Thanks for catching this. Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.