From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BE7FECE564 for ; Tue, 10 Sep 2024 09:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LSnrEblsZ1rxv3QKui05vqakcbf2hprW+co/tId6XeA=; b=nn1aBDWQksjA4f+vAB1q9e4Div KF8kSoLV6TYUZtYLLLo+3JGGFfXV391j3+VP7CzmKRSpGZveiolH7dDX3kn8RzqE6y5ytNoTPl93Y mmmpMesfMV2cCnZDimP9pbjWyrkVoOD9hnCLd8sGyX3swuFghtzga0wv4FlkBebge/IAGTePzHNUU Q+XAFCbtKVH5GSBNr5WTyudJC/RNYI5gZd1S8fpap+EGURLsLEua8ClZB1kg1Vz59QNYKoE1d69rg YxloekZiJ/Ii7snetgaS9uIIJRfwsKqQGu3hJMmTrKjNg+tTAOuwpexrXzD7bFXKItzq7pMDn1m62 MxVmBMwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snww3-00000004xkY-3xrL; Tue, 10 Sep 2024 09:13:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snwrl-00000004wam-1mNg for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 09:08:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 52E015C0208; Tue, 10 Sep 2024 09:08:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72A11C4CEC3; Tue, 10 Sep 2024 09:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725959332; bh=T/HKp5JbA0TTvWWFoCQ/ayf2yy3UYyJBk7cb6yAQ8wc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cObyiDRb4NHLiFz1ocLk8sYrWXRftoejhpEa3/CbdSGHkE0LKfV8ZVaFQNFhBy+mj brdOsuvmmnRGhoYH94/GPx1anwbKmSTb1EwhDB2Cy5fHnY8DDjw2HAsllCb+F6i20+ syTH/VCqrz6QAgMMe943ipoGOxxWoUj1cUJcmJgoStvi942uKFuP/s4udIIipWgm+y X3Pvy+Nz8boAV5pD2RhGudxwvK8hFqhGNqB9KsWl1XyGAJr/nS4GB5uK989VRYAUFb p33/CLtx6MNqiLk9blYcNlewQi9jaKKYPCSY5BUtvU/ssPn5f3jFLlLQAhQ9f+WDP9 Hxcs+r5JFxPMg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1snwri-00Bfjh-3y; Tue, 10 Sep 2024 10:08:50 +0100 Date: Tue, 10 Sep 2024 10:08:49 +0100 Message-ID: <86v7z37u5a.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas , Will Deacon , Anastasia Belova Cc: Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: Re: [PATCH v2] arm64: KVM: define ESR_ELx_EC_* constants as UL In-Reply-To: <20240910085016.32120-1-abelova@astralinux.ru> References: <865xr5856r.wl-maz@kernel.org> <20240910085016.32120-1-abelova@astralinux.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, will@kernel.org, abelova@astralinux.ru, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_020853_596946_BAB92744 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 10 Sep 2024 09:50:16 +0100, Anastasia Belova wrote: > > Add explicit casting to prevent expantion of 32th bit of > u32 into highest half of u64 in several places. > > For example, in inject_abt64: > ESR_ELx_EC_DABT_LOW << ESR_ELx_EC_SHIFT = 0x24 << 26. > This operation's result is int with 1 in 32th bit. > While casting this value into u64 (esr is u64) 1 > fills 32 highest bits. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: aa8eff9bfbd5 ("arm64: KVM: fault injection into a guest") > Signed-off-by: Anastasia Belova nit: the subject line is misleading, as this doesn't only affect KVM, but the whole of the arm64 port (the exception classes form a generic architectural construct). This also probably deserve a Cc stable. Will, Catalin: I'm happy to queue this in the KVM tree, but if you are taking it directly: Acked-by: Marc Zyngier Thanks, M. -- Without deviation from the norm, progress is not possible.