Re: [PATCH] KVM: arm64: Synchronize SMEN on vcpu schedule out

* Re: [PATCH] KVM: arm64: Synchronize SMEN on vcpu schedule out
  2022-12-20 10:50 [PATCH] KVM: arm64: Synchronize SMEN on vcpu schedule out Dong Bo
@ 2022-12-20 10:15 ` Marc Zyngier
  2022-12-21 13:34   ` Mark Brown
  2023-01-23 20:26 ` Oliver Upton
  1 sibling, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2022-12-20 10:15 UTC (permalink / raw)
  To: Dong Bo
  Cc: linux-kernel, linux-arm-kernel, kvmarm, kvmarm, Nianyao Tang,
	James Morse, Alexandru Elisei, Suzuki K Poulose, Oliver Upton,
	Catalin Marinas, Will Deacon, Mark Brown

+ Mark

On Tue, 20 Dec 2022 10:50:24 +0000,
Dong Bo <dongbo4@huawei.com> wrote:
> 
> From: Nianyao Tang <tangnianyao@huawei.com>
> 
> If we have VHE and need to reenable SME for host in
> kvm_arch_vcpu_put_fp, CPACR.SMEN is modified from 0 to 1. Trap
> control for reading SVCR is modified from enable to disable.
> Synchronization is needed before reading SVCR later in
> fpsimd_save, or it may cause sync exception which can not be
> handled by host.
> 
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: James Morse <james.morse@arm.com>
> Cc: Alexandru Elisei <alexandru.elisei@arm.com>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Oliver Upton <oliver.upton@linux.dev>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: Nianyao Tang <tangnianyao@huawei.com>
> ---
>  arch/arm64/kvm/fpsimd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c
> index 02dd7e9ebd39..f5799f571317 100644
> --- a/arch/arm64/kvm/fpsimd.c
> +++ b/arch/arm64/kvm/fpsimd.c
> @@ -184,6 +184,7 @@ void kvm_arch_vcpu_put_fp(struct kvm_vcpu *vcpu)
>  			sysreg_clear_set(CPACR_EL1,
>  					 CPACR_EL1_SMEN_EL0EN,
>  					 CPACR_EL1_SMEN_EL1EN);
> +		isb();
>  	}
>  
>  	if (vcpu->arch.fp_state == FP_STATE_GUEST_OWNED) {
> -- 
> 1.8.3.1
> 
> 

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread