From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 826B9C43458 for ; Tue, 30 Jun 2026 10:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7XUNh2xZ+zxsc4m1oKNNe2grhWxc/9LAqKvL6GOxjTE=; b=B+FpuPKwuOpX0YZqSfB3GTOgIZ xgp7dYeWiPiF650pBhgB0vtueVRtCU4RueuVvJWK6Jpo0t0ygPqfZcymZyvB0/aI9vhVA+BguOGOa XyCkZIUJ0M/Ns8gxWJtzJC0GMAkqf1F7cijihaSqdPXN54iLJTy89SK7MoxKNJ/nopPBNjrcrsbyA BYYqw7RYaNKIIIx58Vx/ZWJH/VfA3xgU8Xe0MsLISebIxD4vlXrRe7LzICHQomFK+tyduZFc/XU3k UtQ+Sp0naoR2eVdnF+SOn3qGytifuoAKV0LFSGN9LqgxCzThhCSCkHQ72lG85MkTycz5FGMVj1e5M h6odX+jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weW6U-0000000Giqk-0nsZ; Tue, 30 Jun 2026 10:54:10 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weW6S-0000000Giqc-2mkU for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2026 10:54:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id EFF92600C3; Tue, 30 Jun 2026 10:54:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97DB71F000E9; Tue, 30 Jun 2026 10:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782816847; bh=7XUNh2xZ+zxsc4m1oKNNe2grhWxc/9LAqKvL6GOxjTE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=X2uy8AfHwtHF0wRDgaE7g4aiKyldyWQrtNyErgp1exNnCRystRDF/nRD4TN5XDJ/v c4d1r+IMrpcHszxihBDru5JKvu28nYxG1blVJKdHxCABJTTlMkJmDVfuE9GRjpo2hz uViG0Yz6Q9Yr8LKmCBReXkWW2H6TrVmA1T0IOYUhAQUXATG0ICWEoRPyA2tGggArBA MsWjTXDlwjBBePOqwZeu305qL5JC3fYUPjdyOnFSrZ1LxNVaSYLBjms0DQv9prRtcr b/ipnzolIFJEJi6J2fF+uAzqDecWqz7UcAe8WydxiWYQKzZc+OjAPRl/yby28g7sxF a33NHauFqG3mA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1weW6O-0000000HREb-3tTn; Tue, 30 Jun 2026 10:54:05 +0000 Date: Tue, 30 Jun 2026 11:54:04 +0100 Message-ID: <86wlvgpacz.wl-maz@kernel.org> From: Marc Zyngier To: Jon Hunter Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, "linux-tegra@vger.kernel.org" , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Mark Rutland , Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Ge Gordon , BST Linux Kernel Upstream Group , Jesper Nilsson , Lars Persson , Alim Akhtar , Ivaylo Ivanov , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dinh Nguyen , Matthias Brugger , AngeloGioacchino Del Regno , Thierry Reding , Bjorn Andersson , Konrad Dybcio , Andreas =?UTF-8?B?RsOkcmJlcg==?= , =?UTF-8?B?Ill1LUNodW4gTGlu?= =?UTF-8?B?IFvmnpfnpZDlkJtdIg==?= , Heiko Stuebner , Shawn Lin , Orson Zhai , Baolin Wang , Michal Simek Subject: Re: [PATCH v3 12/17] arm64: dts: nvidia: Add EL2 virtual timer interrupt In-Reply-To: <3c714ae3-8f62-4785-9f61-ba9899fd70d8@nvidia.com> References: <20260523140242.586031-1-maz@kernel.org> <20260523140242.586031-13-maz@kernel.org> <3c714ae3-8f62-4785-9f61-ba9899fd70d8@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, lpieralisi@kernel.org, guohanjun@huawei.com, sudeep.holla@kernel.org, catalin.marinas@arm.com, will@kernel.org, rafael@kernel.org, mark.rutland@arm.com, daniel.lezcano@kernel.org, tglx@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, gordon.ge@bst.ai, bst-upstream@bstai.top, jesper.nilsson@axis.com, lars.persson@axis.com, alim.akhtar@samsung.com, ivo.ivanov.ivanov1@gmail.com, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dinguyen@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, thierry.reding@kernel.org, andersson@kernel.org, konradybcio@k ernel.org, afaerber@suse.de, eleanor.lin@realtek.com, heiko@sntech.de, shawn.lin@rock-chips.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, michal.simek@amd.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jon, On Tue, 30 Jun 2026 10:42:34 +0100, Jon Hunter wrote: > > Hi Marc, > > On 23/05/2026 15:02, Marc Zyngier wrote: > > The ARMv8.2 based CPUs used in a number of nvidia SoCs are missing > > the EL2 virtual timer interrupt. Add it. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/boot/dts/nvidia/tegra194.dtsi | 2 ++ > > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 3 ++- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi > > index 849694f751d90..45cc180ac9973 100644 > > --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi > > +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi > > @@ -3163,6 +3163,8 @@ timer { > > > (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + > (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > > interrupt-parent = <&gic>; > > always-on; > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > index 04a95b6658caa..ab9813f9ba30c 100644 > > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > @@ -5872,7 +5872,8 @@ timer { > > interrupts = , > > , > > , > > - ; > > + , > > + ; > > interrupt-parent = <&gic>; > > always-on; > > }; > > Sorry for the delay. I gave this a test because I observed the warning > that was added on the Tegra194 and Tegra234 platforms. This change > fixes the warning for Tegra234, but on Tegra194 the platforms I tested > hang on boot. It appears to be similar to the issue that Marek saw on > his platforms and so I am wondering if Tegra194 also doesn't have this > wired up? I think you are in a better position than me to find out. It also could be a firmware issue not making the PPI a Group-1 interrupt, and therefore not allow Linux to configure the interrupt. > > Was there any resolution to the issue reported by Marek? > > FYI, the Tegra194 SoC has the 'NVIDIA Carmel ARM v8.2' CPUs [0]. There is no resolution so far. Florian was going to check what the deal is with the Broadcom-related systems, but hasn't come back with an answer yet. The possibilities are as follows: - remove the interrupt for the EL2 virtual timer and live with the warning - add a patch such as [1], which should document the reason why this is now working (and fallback to the EL2 physical timer) I'm happy either way, as long as we know exactly what we are dealing with on each affected platform. Thanks, M. [1] https://lore.kernel.org/all/878q898ulx.wl-maz@kernel.org/ -- Without deviation from the norm, progress is not possible.