From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 993E3C5AC7A for ; Fri, 7 Aug 2026 10:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uZTb1Zup+2X3ab/B+KoI5OrbnIH6x6juw1nSiD4LMu0=; b=MVNO4A/XrSeHtOaIpj8x/pysl3 rIS8NNI5Ae27lUgfeT44NfTogKiwbdyALjx81YE2aoQWUrdrfDHu/GqvTV5gSFF3H5PJmK1OXuL6n DlXqZJj10sa2dXauv5UaKreVpOJ2fo8g+3G8YYDOhhaBFwr4UF/lluS0lU/DWdZzZT3BURtgOEC36 xGPUU4Ks0+2/+nmmMpODE2eK5cCL4M8d1lalMsTvMjApaciU+NVHbZ5Yj4wYt6nEQs6uROyumEnl3 HSXWefz3iWiwF8iQfjVqfdvnNeMkt/yqlv34DhdzcxyuYqqNk+O1P8Dv+kR2LI6jJSuck5OTAiGIq WzWj9pjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsIGn-00000007mGG-22k2; Fri, 07 Aug 2026 10:57:45 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsIGl-00000007mG8-1NYD for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2026 10:57:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5561460DB7; Fri, 7 Aug 2026 10:57:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C9981F000E9; Fri, 7 Aug 2026 10:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786100262; bh=uZTb1Zup+2X3ab/B+KoI5OrbnIH6x6juw1nSiD4LMu0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jQzBgLvShwZCO9BmKy5JOmcRYYvPr/oy2PVotZ5S8jM1QMlv+VlMseBoJ5sj7mYJO j2pgV86p7lvMf5UZEUiUS1gugMNWsxvRy4iVgQdlUfhgbef4y00S/sjbon7E5orOSv WZ1J0MidHDF7itzbm3Imkq3/6fDIiHdSuCiUPGJLSZEln4yfezq6wZyjnLh+cKDpOs cEMVqLV2voa28ZEDYsFkz2qMP+93TF13JkBpUGAIasn6vX4bypROf4oVp1FBZzu4yg BZ/AzxOdEcl7ScuzNh6UptNol6E8iU2z2oJIB6w1TPSDAcAp8XPIKAiOuDieX30Z// tSGSkdeiMuMXg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wsIGi-0000000DK4O-0WhA; Fri, 07 Aug 2026 10:57:40 +0000 Date: Fri, 07 Aug 2026 11:57:39 +0100 Message-ID: <86y0ei9p0c.wl-maz@kernel.org> From: Marc Zyngier To: Vladimir Murzin Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, ruanjinjie@huawei.com, liaochang1@huawei.com Subject: Re: [RFC PATCH v2 45/45] irqchip/gic-v5: Add NMI support for IPIs In-Reply-To: <5a78805e-ce2b-4571-a162-9e713f4c0678@arm.com> References: <20260727163453.7969-1-vladimir.murzin@arm.com> <20260727163453.7969-46-vladimir.murzin@arm.com> <861pcab5gf.wl-maz@kernel.org> <5a78805e-ce2b-4571-a162-9e713f4c0678@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vladimir.murzin@arm.com, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, ruanjinjie@huawei.com, liaochang1@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 07 Aug 2026 11:42:12 +0100, Vladimir Murzin wrote: > > On 8/7/26 11:17, Marc Zyngier wrote: > > On Mon, 27 Jul 2026 17:34:53 +0100, > > Vladimir Murzin wrote: > >> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > >> index 7eb07e3bdb4c..0091bb5f7662 100644 > >> --- a/kernel/irq/manage.c > >> +++ b/kernel/irq/manage.c > >> @@ -1370,9 +1370,14 @@ static bool irq_supports_nmi(struct irq_desc *desc) > >> struct irq_data *d = irq_desc_get_irq_data(desc); > >> > >> #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > >> - /* Only IRQs directly managed by the root irqchip can be set as NMI */ > >> - if (d->parent_data) > >> - return false; > >> + struct irq_data *data; > >> + /* > >> + * Only IRQs directly managed by the root irqchip can be set > >> + * as NMI unless we inherit NMI from parent > >> + */ > >> + for (data = d->parent_data; data; data = data->parent_data) > >> + if (!(data->chip && data->chip->flags & IRQCHIP_SUPPORTS_NMI)) > >> + return false; > > Maybe we should just trust the local irqchip to do the right > > thing. After all, the core code shouldn't be in the business of > > sanitising broken irqchip drivers advertising random crap. > > > > That is indeed bit I was not really sure about, if we decide that we > can trust local irqchip then I assume we just drop the check? Yup. Drop the CONFIG_IRQ_DOMAIN_HIERARCHY hack, and only consider the local information. Thanks, M. -- Without deviation from the norm, progress is not possible.