From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73E28D3940B for ; Thu, 2 Apr 2026 10:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jUQpN1j3wh1u4OAm4KFYItBmRTyUEJPdObc7g9aMDIA=; b=DjjTbnotnjwpyPTr8GG5FzrBgE +krUPldXlYxlsKm4Xj6LAhGEiyRvhoe2gsrlyGtfIxODdO4O+KhUb9xqBd01koyJi02A5Dk1qZD9Y lFpBlMhWWxXdE82yb8L1DhwGjkgElxbzkD6fEIne1LBYmmKKhz1Ja5mN3QNSFuM4av9sKqSxs5zNM LJ2A4RN1jg+Nbrhu4nhKvylVSMEt1I2u1GkbhHlmPK7AMFfcbcRI+rnz2HiTlD6fwFKQo/oWQPMJl c/ByNKiNZOq9LJ1I5jHjUErgdLh3oN+41aivD2n0ofh79oES8ewdapwjZkvzr6PTlZxtq1PyvAuH+ x57VeJJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w8EyD-0000000HLxp-3Wpe; Thu, 02 Apr 2026 10:08:13 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w8EyC-0000000HLxO-2WoA for linux-arm-kernel@lists.infradead.org; Thu, 02 Apr 2026 10:08:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 958E96186D; Thu, 2 Apr 2026 10:08:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 424ECC116C6; Thu, 2 Apr 2026 10:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775124491; bh=CBS+GA9IR1SPiqF1Zs3xHYu+WRK7gcHd7ay77pLTTSQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DDQH8THI/aMmucvI6wWnm3KXZEZqhFulzEirJn8NerYH3ZBOf8F3ZLx+/Zh5HprfH 1lXp9wV6RfUmEXC0YFNV+eXoUSik/8mwCkCLFEQTl1g1NDJQh7frn/D8XMqVxN1kH+ 88oI/W+z/9TzPu8/WOnZh71qzNpLYN48XWYjX25ZsQXfFP6lX0eKHSDJS3hM9aDZq4 sxnZG78mVSzAQCxH4UId0BDxjGJMx8wd6LAHcsaDjOrC8jwh5F6N8D1YNJyiW86/zI 7ALJ49MORB0CqhjcdWqA5zEvPOlEdyHmOTgePAqeymOlFIlYZuSt8ku5ONlE9gtz9G BbOaJ3Kz4JzEA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w8Ey8-00000008DGP-3CBA; Thu, 02 Apr 2026 10:08:08 +0000 Date: Thu, 02 Apr 2026 11:08:08 +0100 Message-ID: <86y0j53caf.wl-maz@kernel.org> From: Marc Zyngier To: Steffen Eiden Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Andreas Grapentin , Arnd Bergmann , Catalin Marinas , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Gautam Gala , Hendrik Brueckner , Janosch Frank , Joey Gouly , Nina Schoetterl-Glausch , Oliver Upton , Paolo Bonzini , Suzuki K Poulose , Ulrich Weigand , Will Deacon , Zenghui Yu Subject: Re: [PATCH v1 07/27] KVM: arm64: Provide arm64 KVM API for non-native architectures In-Reply-To: <20260402042125.3948963-8-seiden@linux.ibm.com> References: <20260402042125.3948963-1-seiden@linux.ibm.com> <20260402042125.3948963-8-seiden@linux.ibm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: seiden@linux.ibm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Andreas.Grapentin@ibm.com, arnd@arndb.de, catalin.marinas@arm.com, borntraeger@linux.ibm.com, imbrenda@linux.ibm.com, david@kernel.org, ggala@linux.ibm.com, brueckner@linux.ibm.com, frankja@linux.ibm.com, joey.gouly@arm.com, oss@nina.schoetterlglausch.eu, oupton@kernel.org, pbonzini@redhat.com, suzuki.poulose@arm.com, Ulrich.Weigand@de.ibm.com, will@kernel.org, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 02 Apr 2026 05:21:03 +0100, Steffen Eiden wrote: Drive-by comment as I was idly going through this patch. [...] > diff --git a/include/kvm/arm64/kvm_host.h b/include/kvm/arm64/kvm_host.h > new file mode 100644 > index 000000000000..3a434f47497b > --- /dev/null > +++ b/include/kvm/arm64/kvm_host.h [...] > +static inline bool kvm_supports_32bit_el0(void) > +{ > + return false; > +} > + This looks wrong. The original file still has: #define kvm_supports_32bit_el0() \ (system_supports_32bit_el0() && \ !static_branch_unlikely(&arm64_mismatched_32bit_el0)) which should not be tampered with. I guess we are simply lucky that the preprocessor is braindead enough to make this sort of things go unnoticed, but I'd expect this predicate to be directly provided by the s390 code one way or another. Thanks, M. -- Without deviation from the norm, progress is not possible.