From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECEC1C54798 for ; Sat, 2 Mar 2024 11:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+mLXGtYs3ZeLiK/gKsjUShfL+oyXQl6Wbl5peBpwmQg=; b=RHD86US0NCekAr dLrolKclCC3vlCeyJD2Wt7V1J+pvib6murZHYxFBS/Jw4d4tu+De6oMBnJTU+vqj9ZG/sVzWdiyi6 +qi1tAqHZ9N3/5nkUMYj4Q+FSPErWoMQWh92O9pHlAieN6vGIEpHJ4fCn6YOI0W0keg7qQeixpxtQ Fa/8K2VIcA9gYL3QFSpIFNRi5ApRgoVglrWiKKpbSJeBlovSoHEG+zOI4RbYCPRBlZwgHvZBaTFvb Z2kIfUb2ojeT3FFKWrLoGzoYzaqz95jn129r3mFLoUhXomuWz4+o5m6+F3jCW6JnyOTaG88s7OJUR HvR10MoNo2QaktjsBl7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgNZy-00000003QPk-47sH; Sat, 02 Mar 2024 11:30:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgNZv-00000003QOj-1XTP for linux-arm-kernel@lists.infradead.org; Sat, 02 Mar 2024 11:30:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A529B61344; Sat, 2 Mar 2024 11:30:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A5BC433F1; Sat, 2 Mar 2024 11:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709379054; bh=oQ+DxDSSOmlUj3fhF7GDj4r02Xb+mjiohzUCcRJFJ0o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dA3hpWMg0saKPgHbbyBZk8IzLnWTeqRvXU2aavzMLNQhEI8vCOPq7RpquUVLzeEXz Tzb7JMHSlJAQg5CNV0nt4UPRp6TxKehG8xIQc/MlWQ/z9+b59DtNZsJ31jch/Hu6fI pMxoT4mgbRXyks/Ywzh2zCvD1KgtnxjCz/0u730Jr+0ICIMW4ILAPPU/1O2JZsG1Ea z2aqCOkDWskh0R36Vm6UhEQrWmlvkfNrFt+DH9x0mMcMzNicKn5JXU2hOsr3Stiqta X+QGi8/YeQ6xtRm4S5kQQzcwpVLTlchcb2AMoL97fd+x6U8I5lX3b7h6XR85mG/h93 MJkenmFOogbRQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rgNZr-008lX5-Rm; Sat, 02 Mar 2024 11:30:51 +0000 Date: Sat, 02 Mar 2024 11:30:51 +0000 Message-ID: <86y1b027mc.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] KVM: arm64: Reuse struct cpu_fp_state to track the guest FP state In-Reply-To: <20240229-kvm-arm64-group-fp-data-v2-2-276de0d550e8@kernel.org> References: <20240229-kvm-arm64-group-fp-data-v2-0-276de0d550e8@kernel.org> <20240229-kvm-arm64-group-fp-data-v2-2-276de0d550e8@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240302_033055_495448_55864970 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Feb 2024 21:47:35 +0000, Mark Brown wrote: > > At present we store the various bits of floating point state individually > in struct kvm_vcpu_arch and construct a struct cpu_fp_state to share with > the host each time we exit the guest. Let's simplify this a little by > having a struct cpu_fp_state in the struct kvm_vcpu_arch and initialising > this while initialising the guest. This structure is only useful to the physical CPU we run on, and does not capture anything that is related to the guest state. Why should it live in the vcpu structure, duplicating things we already have? This is just making things even more opaque. If you need to add such a structure so that you can know what to save/restore on context switch, then attach it to the per-CPU data structure we already have. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel