From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452D7C04AB4 for ; Fri, 17 May 2019 08:46:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17627206A3 for ; Fri, 17 May 2019 08:46:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YUXSTycI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="G89E42Pa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17627206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yrJpf0aXBrSPDfsislTkf9to7FWhd6txpErW23aLt4w=; b=YUXSTycI0oJizx +nt3VfW5FlqX9NXPQf8ng6P3w/2AzOiU3dqVeHhLhQYMoAx7jGFNzX0fs/I4tJ7lwIDCLNuKvbCtr H4brQu2lBDk7FBINQETCB5yOeFCXhSHiz24OY5dh4xPjLAbYgX08fpJpn0DzgiObGNffjV9LlTTV/ aTr1zi8EU/R6FMu6kkM5BKzgXGgHUrH123LdhmOn8jy+qORv1pzoOo1YJPuinA9Z3tnOZjpJTd88B wjuxsDDG46ikWRt2RgB0TN/snUiwRmwiO/BfrYYxvU7uek7m/DS0De/2q9CNcPSMUEk6ynVPSs6Ux 5+2598q1/SLqG+qxCwgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRYV9-0001RC-17; Fri, 17 May 2019 08:46:03 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRYV3-0001Pj-SA for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2019 08:46:00 +0000 Received: by mail-wr1-x443.google.com with SMTP id m3so6045312wrv.2 for ; Fri, 17 May 2019 01:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=zANvFWcmKo8EuxHsHKy0+A0TL7ZrRo4zFgliyPjUUj4=; b=G89E42Pa8/i0yLqFzDrR7voEnExiA0bj6nxX/4R5r20F5lboYP6d80VB+yt+uns+cU CLh2KVwNUMjJb6+O8Y93sHBY/NUt++OAt1tQ/3SDeNABXCdBOafrfibAkCOB3L+feT2m s8KKjZzoi+CZ3QwFklDFwfqL5xNo4+o+laL2vGQMvFhfjpOpDpH/nYqr7zoFiWsDa+wF eDvewynCTMPVD2dTSK+2OE91AyC87rburN6cEoGRymtk4UVzaG5SUtZU/qTII1JxVCcO KybayTKa8Vw6kkWVbJAPaHWf/bzv2rVzxFntNfCUMdPh8jfM3u2rwPh3bOb1tqB2Uf0v rEWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=zANvFWcmKo8EuxHsHKy0+A0TL7ZrRo4zFgliyPjUUj4=; b=jTUUzGU3lm3NMxu94JyI2GdQ2LYPn6OwbieNq6p3N5PMRf1O59jrSaEVw3W+83kD1/ oNSdxh2yBJWnI+eLRKioESzwVvi4I/2qUQhOVGsRM/vdjfPP1Y1PlECS8j+NlmWAZbmF ak20tC5DWC/BirjTFYsKXKMTwf5BmVF1y9ldy8cHDb4/q3WEmFDevV+bCdHyQqLGghtd f8ktJoy2BdZqTcEwUQ5BmEsSKjLGahj8rdlFh8aHl9vp7QkxEIEfP3IYcRVK8LSJa+xY rY5u8I4l5c5DwP0k6lhV7KSQd21msTcCjp7VlGTJk41ORRnd+Aa+8pmKPjm4plqRsEbe Qrxw== X-Gm-Message-State: APjAAAWPPiuf30QW3wcA0xIjb2efSKo+TAgHX7UW7a3uxv8MS8c73B4C KIpQyRAdGmITe9qg5ycVEVeCWQ== X-Google-Smtp-Source: APXvYqwBWa7+jkAlmZTk18op83oeFtloTczIxdn6drxP9ta4epZYJ52bFHtjfdYK8jPP5UQwHeCBig== X-Received: by 2002:adf:ec42:: with SMTP id w2mr32445004wrn.77.1558082756357; Fri, 17 May 2019 01:45:56 -0700 (PDT) Received: from localhost ([2620:10d:c092:180::1:fcd4]) by smtp.gmail.com with ESMTPSA id v17sm5528287wmc.30.2019.05.17.01.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 01:45:55 -0700 (PDT) From: Loys Ollivier To: Robin Murphy , Johan Hovold , Matthias Brugger Subject: Re: [PATCH v2] gnss: get serial speed from subdrivers In-Reply-To: <69b5e90c-c1c3-9f2e-57a8-64741182a96e@arm.com> References: <1558024626-19395-1-git-send-email-lollivier@baylibre.com> <69b5e90c-c1c3-9f2e-57a8-64741182a96e@arm.com> Date: Fri, 17 May 2019 10:45:53 +0200 Message-ID: <86y33579ku.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190517_014557_962591_DA68E02E X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: baylibre-upstreaming@groups.io, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Colin Ian King , Corentin Labbe , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 16 May 2019 at 19:02, Robin Murphy wrote: >> -/* >> - * FIXME: need to provide subdriver defaults or separate dt parsing from >> - * allocation. >> - */ >> static int gnss_serial_parse_dt(struct serdev_device *serdev) >> { >> struct gnss_serial *gserial = serdev_device_get_drvdata(serdev); >> struct device_node *node = serdev->dev.of_node; >> - u32 speed = 4800; >> + u32 speed; >> >> - of_property_read_u32(node, "current-speed", &speed); >> + of_property_read_u32(node, "default-speed", &speed); >> >> gserial->speed = speed; > > Hmm, maybe it's a bit too convoluted for the compiler to warn about, but > if a "default-speed" property is not present, gserial->speed will now be > assigned an uninitialised value. I don't know what the intent is neither > the driver nor the DT provides a value, but you'll either need to bring > back the fallback initialisation above or propagate errors from > of_property_read_u32(). > > Robin. > Robin, Good point, thank you for your review. I'll think about it and see about a fallback scenario. I would be in favour of propagating the error because default values are very dependent on the hardware in use. Best, Loys _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel