From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9283BCCF9E0 for ; Tue, 28 Oct 2025 10:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p0P0p7pWVw6Zu9bcfIZsXnpvPvZr/5WHW2oMXRkEU8E=; b=kRKjZSw+VzBK0AvVTt8Pd+pXa3 JbEXX8twpjrTezZ/CO1YHc7DDfpN6nHh0ADoCHnMymVII1G2JPVzCcRivwJY9V1KRphWsZKWkvVx3 yfmrgM+WYMr+KutgbQnOJGnGjJ8jB4KtTC8+09STDIgH/SPOwXcVCA5LJRkcuQ42afNQdZWFK8shN 4VBbCu3NdrGRJbp3DFKeNjQRMS5k6aEDOETDK1/BkFqi2kPKvWriso789vXGigsxa0Qnc8i5uS1cm Pjp6G9JJJA4gpilAAXkRm3Yrj/dLFmAlTBsGuR8bfDPEAsQ7Qk2nFHhhc1z9rR4GfgMH8Bf3G0XHV lwK96Cqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDh6O-0000000FltD-1Zl4; Tue, 28 Oct 2025 10:38:56 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDh6M-0000000Flsl-2px6 for linux-arm-kernel@lists.infradead.org; Tue, 28 Oct 2025 10:38:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C250944EDE; Tue, 28 Oct 2025 10:38:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BAB0C4CEE7; Tue, 28 Oct 2025 10:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761647932; bh=D7yB2su+JpWEU/gxLcsdAnmcL24HVifgVoD8o7Fwu1I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Yk7xJLkIel9PFMMlHeJ002D3fvMQz/Z5vn8lYhohprnr9XfaLabSM/fMBBP2u1gI1 0x8qYRGcQVyHPIdGVC0HJpkbycdpm9Q1ubnyTIOFrG/pZSH0xSDUT/p/KCSwi7SPAx n3yXZLQp1ZWgI6XPUr+ufJnQs8CG5h/Qxcv7FIDkXIfcoqfU1Eb2UpXRpQoszXgnEw wjjj64m7fSf2dFixh9f6Va94K7gtog1pIDVGuafz3jEiiJ7wmdNCwPQX9/HpY8ZQVD eczYIQhCJTAdC5d5LnPIDd+PpQGIjOqa8NhhFJtetylb2ZDKHTdzEVC1c6N1477ak/ YXjZdqhJID6wg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vDh6I-00000000Djq-0l4o; Tue, 28 Oct 2025 10:38:50 +0000 Date: Tue, 28 Oct 2025 10:38:49 +0000 Message-ID: <86zf9bux8m.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com Subject: Re: [PATCH v1 1/4] KVM: arm64: Switch reg and val parameter ordering in vcpu_write_sys_reg() In-Reply-To: <20251027113943.1282568-2-tabba@google.com> References: <20251027113943.1282568-1-tabba@google.com> <20251027113943.1282568-2-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251028_033854_737404_A8AB7AD0 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 27 Oct 2025 11:39:40 +0000, Fuad Tabba wrote: > > The vcpu_write_sys_reg() function previously used the signature: > void vcpu_write_sys_reg(struct kvm_vcpu *vcpu, u64 val, enum vcpu_sysreg reg); > > This was inconsistent with related functions and macros such as > __vcpu_assign_sys_reg() and __vcpu_rmw_sys_reg(), both of which > have the register parameter before the value. > '(vcpu, reg, ...)' ordering. On the other hand, write_sys_reg() is exactly in the same order as vcpu_write_sys_reg(). I think that's the model to follow. The __vcpu_*_sys_reg() helpers are internal things, really, and if something has to change, I'd rather change those. Thanks, M. -- Without deviation from the norm, progress is not possible.